How to check if all of places are empty?

Question

I wrote this method, because I want to check all of places if textfields, datepicker and radiobuttons are empty when I will press a button, but it doesn't work.

What should I correct in this code, or should I do a method in different way?

public void btn1(ActionEvent event) throws Exception {
    if(name.getText().trim().isEmpty() && surname.getText().trim().isEmpty() && pesel.getText().trim().isEmpty() && adres.getText().trim().isEmpty() && email.getText().trim().isEmpty() )
        if(dateOfBirth.getValue() == null)
            if(sexM.isSelected() || sexF.isSelected() || sexG.isSelected()){
                lbl.setText("All of places have to be filled");
            } else {
                 Stage primaryStage = new Stage();
                 Parent root = FXMLLoader.load(getClass().getResource("\\Step2.fxml"));
                 Scene scene = new Scene(root);
                 scene.getStylesheets().add(getClass().getResource("application.css").toExternalForm());
                 primaryStage.setScene(scene);
                 primaryStage.show();
            }
        }
    }
}

https://stackoverflow.com/questions/35948307/javafx-check-whether-a-text-property-is-blank-and-not-just-empty — SedJ601, Jun 09 '17 at 18:27
Furthermore by using 3 ifs instead of one there are cases where neither the label's text is set nor the new stage is shown. (If one of the text fields is non-empty or the datepicker is non-empty.) Is this the desired behavior? — fabian, Jun 09 '17 at 18:31
Possible duplicate of [How to check if textfield is empty?](https://stackoverflow.com/questions/32866937/how-to-check-if-textfield-is-empty) — Developer66, Jun 09 '17 at 18:35
Please accept the answer that works for you @OmarAlhadidy https://meta.stackexchange.com/a/5235 — Developer66, Sep 16 '17 at 14:04

Developer66 · Answer 1 · 2017-06-09T18:47:03.557

Try this:

public void btn1(ActionEvent event) throws Exception {
    if (name.getText().trim().length() == 0 && surname.getText().trim().length() == 0
            && pesel.getText().trim().length() == 0 && adres.getText().trim().length() == 0
            && email.getText().trim().length() == 0 && dateOfBirth.getValue() == null && sexM.isSelected()
            || sexF.isSelected() || sexG.isSelected()) {
        lbl.setText("All of places have to be filled");
    } else {
        Stage primaryStage = new Stage();
        Parent root = FXMLLoader.load(getClass().getResource("\\Step2.fxml"));
        Scene scene = new Scene(root);
        scene.getStylesheets().add(getClass().getResource("application.css").toExternalForm());
        primaryStage.setScene(scene);
        primaryStage.show();
    }
}

Replace all isEmpty() with .length()

score 0 · Answer 2 · answered Jun 09 '17 at 19:03

You'll notice there is a lot of repeated code when checking the TextFields. If would be better to get rid of this.

Furthermore by using 3 ifs you probably made some mistake: You allow for cases where neither a new stage is shown nor the label is set to an error message.

Also the part with the sexes looks like you use CheckBoxes/RadioButtons that are mutual exclusive. In this case you should use a ToggleGroup which allows you to check for a selection using code similar to the one used with the DatePicker:

/**
 * Helper method for checking, none of the TextFields passed are empty.
 */
private static boolean allFilled(TextField... textFields) {
    for (TextField textField : textFields) {
        if (textField.getText().trim().isEmpty()) {
            return false;
        }
    }
    return true;
}

ToggleGroup sexToggleGroup = new ToggleGroup();

sexM.setToggleGroup(sexToggleGroup);
sexF.setToggleGroup(sexToggleGroup);
sexG.setToggleGroup(sexToggleGroup);

if (allFilled(name, surname, pesel, adres, email)
      && dateOfBirth.getValue() != null
      && sexToggleGroup.getSelectedToggle() != null) {
    ... show new stage ...
} else {
    ... display error message ...
}

score 0 · Accepted Answer · answered Jun 12 '17 at 18:06

It's my solution. Maybe that will help someone.

@FXML
public void btn1(ActionEvent event) throws IOException {

    TextField[] fieldList = new TextField[]{name, surname, pesel, adres, email};

    ToggleGroup sexToggleGroup = new ToggleGroup();     
    sexM.setToggleGroup(sexToggleGroup);
    sexF.setToggleGroup(sexToggleGroup);
    sexG.setToggleGroup(sexToggleGroup);

    boolean right = false;

    for(TextField listF : fieldList)
    if(listF.getText().equals("") || dateOfBirth.getEditor().getText().equals("") || sexToggleGroup.getSelectedToggle() == null){
        lbl.setText("All of places have to be filled");
        right = true;
        break;
    } else {
        right = false;
    }
    if(right == false){
        Stage primaryStage = new Stage();
        Parent root = FXMLLoader.load(getClass().getResource("\\Step2.fxml"));
        Scene scene = new Scene(root);
        scene.getStylesheets().add(getClass().getResource("application.css").toExternalForm());
        primaryStage.setScene(scene);
        primaryStage.show();
    }
 }

How to check if all of places are empty?

3 Answers3