My getView method in my custom array adapter is not working

Question

can you give me some advice about my getView methood;
I have custom adapter that extends ArrayAdapter(context, id, list)

public class myCustomAdapter extends ArrayAdapter{


private List obj = null;
public myCustomAdapter(@NonNull Context context, @LayoutRes int resource, @NonNull List objects) {
    super(context, resource, objects);
    obj = objects;

}

@Override
public int getCount() {
    return obj.size();
}

@Nullable
@Override
public Object getItem(int position) {
    return super.getItem(position);
}



@NonNull
@Override
public View getView(int position, @Nullable View convertView, @NonNull ViewGroup parent) {
    Task myTask = (Task) getItem(position);
    if(convertView==null){
        convertView = LayoutInflater.from(getContext()).inflate(R.layout.list_item, parent);
    }
    TextView myTextView = (TextView) convertView.findViewById(R.id.textView);
    myTextView.setText(myTask.getTaskText());
    CheckBox myCheckBox = (CheckBox) convertView.findViewById(R.id.checkBox);
    myCheckBox.setChecked(myTask.getChecked());

    return convertView;
}

}

problem 1 : super: Unchecked call to ArrayAdapter(..) as member of raw type
problem 3 : getTaskText //methood from my Task class// may produce NPE

I would appreciate any help if possible.

score 2 · Accepted Answer · answered Jun 02 '17 at 13:00

 if(convertView!=null){
        convertView = LayoutInflater.from(getContext()).inflate(R.layout.list_item, parent);
}

should be

if(convertView==null){
        convertView = LayoutInflater.from(getContext()).inflate(R.layout.list_item, parent);
    }

you have to inflate when the convertview is null. not when its not null. And then return this from your getView() method

Also i can not see getCount() method. It is also very important to tell the adapter about how many items to inflate

allright that solved me the second problem. Thank You kind sir! — Vlad Skurtolov, Jun 02 '17 at 13:10

score 1 · Answer 2 · answered Jun 02 '17 at 12:59

1

Change this

return super.getView(position, convertView, parent)

to

return convertView;

answered Jun 02 '17 at 12:59

Dishonered

8,449
9
37
50

score 1 · Answer 3 · answered Jun 02 '17 at 13:06

1

You have to inflate convertview when it is null.

if(convertView==null){ convertView = LayoutInflater.from(getContext()).inflate(R.layout.list_item, parent); }

Also return convertview instead of super

answered Jun 02 '17 at 13:06

Nivil Boban

286
1
13

score 0 · Answer 4 · answered Jun 02 '17 at 13:24

I suggest use BaseAdapter, it's basic, ArrayAdapter is BaseAdapter' subclass, In most cases, you do not need to inherit the BaseAdapter, use it directly.

ArrayAdapter adapter = new ArrayAdapter(context, R.layout.list_item, R.id.text, stringList);

public class MyCustomAdapter extends BaseAdapter {

    private List<Task> listData;

    public MyCustomAdapter(List<Task> list) {
        listData = list;
    }

    @Override
    public int getCount() {
        return listData.size();
    }

    @Override
    public Object getItem(int position) {
        return listData.get(position);
    }

    @Override
    public long getItemId(int position) {
        return position;
    }

    @Override
    public View getView(int position, View convertView, ViewGroup parent) {
        if (convertView == null) {
            convertView = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_item, parent, false);
        }
        Task data = getItem(position);
        TextView text = (TextView) convertView.findViewById(R.id.text);
        return convertView;
    }
}

My getView method in my custom array adapter is not working

4 Answers4