4

I have the following code:

Map<String, List<String>> map;
for(String k : map.keySet()){
   List<String> list = map.get(k);
   boolean empty = list.isEmpty();//CME
   if(!empty && somecheck(k, ...)){
      list.clear();
   }
}

And I'm getting ConcurrentModificationException in isEmpty() method. List is an ArrayList. There is no other threads modifying list, because it was created in this method before (and the all map too). The only place modifying list is clear(), but it called after isEmpty() and loop cannot execute on one list twice.

I'm using java 1.7

java.util.ConcurrentModificationException
    at java.util.ArrayList$SubList.checkForComodification(ArrayList.java:1169)
    at java.util.ArrayList$SubList.size(ArrayList.java:998)
    at java.util.AbstractCollection.isEmpty(AbstractCollection.java:86)
P.J.Meisch
  • 18,013
  • 6
  • 50
  • 66
TEXHIK
  • 1,369
  • 1
  • 11
  • 34

1 Answers1

6

From the stacktrace you have given it appears the exception is being thrown in the sub-class implementing the SubList functionality - I assume the lists in your map are actually sublists of another list?

Presumably what is happening is that you are modifying the underlying list after you have created the sublist view (remember, a sublist is just a view onto another list - it does not take an independent copy).

Instead of putting sublists into the map, try taking a copy instead, for example:

map.put(key, new ArrayList(originalList.subList(start, end));
BarrySW19
  • 3,759
  • 12
  • 26
  • 1
    Good sleuthing! – Sam May 31 '17 at 10:08
  • Perhaps, the list values in that map are all sublists of the same source list, so when `clear()` is invoked on one of them during in the loop, calling `isEmpty()` on one of the others in the next iteration will fail… – Holger Jun 09 '17 at 11:16