16

I was wondering how to differentiate between the user tapping submit or skip in the inline post-to-stream FBDialog. Anyone know what to test for?

I am using the latest iOS Facebook Connect in a iOS 4.2 environment.

/**
 * Called when a UIServer Dialog successfully return.
 */
- (void)dialogDidComplete:(FBDialog *)dialog {
    if user tapped submit and post was successful
        alert user of successful post

    if user tapped "skip" (cancel equivalent)
        do not display alert
}
Oh Danny Boy
  • 4,857
  • 8
  • 56
  • 88
  • I recently discovered the following solution to this problem. Please see braceta's answer. https://github.com/ideashower/ShareKit/issues#issue/8 – Oh Danny Boy Feb 07 '11 at 18:29

4 Answers4

33

As Fede and kennbrodhagen said, this looks like the easiest way (until Facebook fixes this bug):


- (void) dialogCompleteWithUrl:(NSURL*) url
{
    if ([url.absoluteString rangeOfString:@"post_id="].location != NSNotFound) {
        //alert user of successful post
    } else {
        //user pressed "cancel"
    }
}
Pavel Alexeev
  • 6,026
  • 4
  • 43
  • 51
5

My understanding is that

- (void)dialogDidNotComplete:(FBDialog *)dialog;

would be called for the skip.

I haven't tested this theory though.

Edit: I tested it now, and my theory is wrong. The code looks like the dialog should call 

- (void)dialogDidNotCompleteWithUrl:(NSURL *)url

on your delegate, but it practise it seems to not do so, as the web page is returning fbconnect://success for a press of the "skip" button. This sounds like a bug to me.

Andy J Buchanan
  • 1,952
  • 14
  • 13
  • 2
    You are correct. dialogDidComplete is called regardless of skip or Publish. Thank you for taking the time to answer. – Oh Danny Boy Dec 13 '10 at 16:23
  • 1
    I was testing this myself and found that dialogDidNotComplete is called when the user closes the dialog with the X in the upper right hand corner. Skipping called dialogDidComplete. – varikin Apr 20 '11 at 16:36
4

I did some experimentation and it seems that when the post is submitted you will get two callbacks: dialogCompleteWithUrl and then dialogDidComplete. When the post is skipped, you will only receive the dialogDidComplete callback.

You could trigger your success alert on the dialogCompleteWithUrl callback. If you wanted to wait until you received the dialogDidComplete callback you could save some state during the dialogCompleteWithUrl callback and then based on that state fire your alert in dialogDidComplete.

During my test the url I received during dialogCompleteWithUrl was of the form "fbconnect://success/?post_id=1627754863_182914058401072"

So if need be you could even peek at this value to further confirm your success, although I expect that if the post really did fail (as opposed to a skip) you will get one of the fail callbacks instead.

kennbrodhagen
  • 4,258
  • 2
  • 26
  • 21
  • I dug into Andy J Buchanan's answer and thought of saving the state. What troubles me is modifying Facebooks code. I have no clue what they may change in the future or the legal consequences of making any modifications. Regardless, thank you for taking the time to answer. – Oh Danny Boy Dec 21 '10 at 20:12
  • 1
    For me both buttons invoke both functions: dialogCompleteWithUrl and dialogDidComplete. The only way to distinguish between them is that when post is actually done, the url has the post_id parameter, when skipped it doesn't. Thanks for the answer! – Fede Mika Aug 24 '11 at 04:03
1

Hello I just follow link by @Oh Danny Boy and I found this solution

from this thread : http://forum.developers.facebook.net/viewtopic.php?pid=303257#p303257 Fixed this by adding the following to webViewDidFinishLoad: in FBDialog.m

[_webView stringByEvaluatingJavaScriptFromString:@"document.getElementsByName('cancel')[0].onclick = function onclick(event) { window.location.href = 'fbconnect://cancel'; return false;}"];

This makes the cancel button correctly call "fbconnect://cancel" rather than "fbconnect://success".

- (void)webViewDidFinishLoad:(UIWebView *)webView {
  [_webView stringByEvaluatingJavaScriptFromString:@"document.getElementsByName('cancel')[0].onclick = function onclick(event) { window.location.href = 'fbconnect://cancel'; return false;}"];

  [_spinner stopAnimating];
  _spinner.hidden = YES;

  self.title = [_webView stringByEvaluatingJavaScriptFromString:@"document.title"];
  [self updateWebOrientation];
}

Its works fine:

But There is one more issue If Facebook Change html then this code will no longer work. My solution to this problem is that :

Instead of putting JavaScript statically just get it from server at regular interval or similer mechanism 

[_webView stringByEvaluatingJavaScriptFromString://We need to control this javascript from server//];

so in future we can change this javascript instead of updating whole application.

I hope in future this bug will be solved http://bugs.developers.facebook.net/show_bug.cgi?id=5958

yogs
  • 788
  • 2
  • 11
  • 29