3

I am trying to use a Handler to have some code execute in some amount of time.

This works well in 2 of my classes, but I'm running on an issue with this one:

One of my class extends Activity, and starts a Thread (that implements Runnable).

In my run() method, I have, as in my other classes: 

mHandler = new Handler();
mHandler.removeCallbacks(StopRequest);
mHandler.postDelayed(StopRequest, 30000);

The program seems to complain:

java.lang.RuntimeException: Can't create handler inside thread that has not called Looper.prepare()

I don't understand why it is posting, could someone please help me?

EDIT: Adding parts of my code:

            out = new PrintWriter(new BufferedWriter(
                    new OutputStreamWriter(clientSocket.getOutputStream())), true);

            out.println("VOICE_CALL_REQUEST");

            // Wait for a response

            // Set a timer (about 30 seconds)
            mHandler = new Handler();
            mHandler.removeCallbacks(StopRequest);
            mHandler.postDelayed(StopRequest, 3000);

            // Ready reply
            InputStream stream = clientSocket.getInputStream();
            BufferedReader data = new BufferedReader(new InputStreamReader(stream));

            String line = data.readLine();
            mHandler.removeCallbacks(StopRequest); // Timer is removed here

And if the timer hits 30 seconds:

    // Stop a call request after some amount of time
    private Runnable StopRequest = new Runnable() {
        public void run() {
            // Send a message to cancel the voice call
            out.println("VOICE_CALL_CANCEL");

            // Close the port
            try {
                clientSocket.close();
            }
            catch (IOException e) { finish(); }
        }
    };

Thanks a lot,

Jary

Jary
  • 85
  • 3
  • 7

2 Answers2

4

You can't create a handler in a worker thread (unless it has a looper, which you normally never do). The handler needs a looper, since it needs a point that evaluates all incoming messages and calls the handler when necessary.

Your handler needs to be in the UI thread. If you want to do something in a worker thread, you need to do your own message handling (you could use synchronized methods in your thread that set member variables which the worker thread checks), or, if your thread is more of the event-driven variety, you could really consider adding a looper - but again, that is not a common practice.

EboMike
  • 76,846
  • 14
  • 164
  • 167
  • Should I just use the Timer class then? Well what I am trying to do is sending a TCP packet and wait for 30 seconds, if no answer was received (ie: other client didn't select a choice), terminate and close the connection. – Jary Dec 06 '10 at 03:46
  • I made a little mistake as well (may not be important), but the class actually extends Activity and not Service. Thanks a lot. – Jary Dec 06 '10 at 03:46
  • Are you reading with a Socket? Can't you just use `Socket.setSoTimeout()`? – EboMike Dec 06 '10 at 03:50
  • The issue is I would like to send a packet after 30 seconds to tell the other side that I am cancelling that request. Will update my code in my initial post. – Jary Dec 06 '10 at 03:57
  • 1
    I found a solution. Defining the handler in the onCreate method fixes it. Rest of the code is identical. Thanks :) – Jary Dec 06 '10 at 04:59
  • Btw, if you accept this answer, we'll both get rep points. Thanks! – EboMike Dec 06 '10 at 05:09
  • so, is it possible to somehow schedule a Runnable from a worker thread? maybe not with Handler? – Vlad Jun 17 '12 at 16:38
  • @Vlad: `Activity.runOnUiThread()`. See here: http://developer.android.com/reference/android/app/Activity.html#runOnUiThread(java.lang.Runnable) – EboMike Jun 18 '12 at 07:58
2

I found a solution. Defining the handler in the onCreate method fixes it. Rest of the code is identical. Thanks :)

Jary
  • 85
  • 3
  • 7