Lag after setting text in OnTextChanged()

Question

Below is an example that replicates my lagging problem. Once I set the text on the EditTextView it takes at least 1.5 seconds for the user to be allowed to input another character.

    amountEditText.addTextChangedListener(new TextWatcher() {
        @Override public void beforeTextChanged(CharSequence s, int start, int count, int after) {}
        @Override public void afterTextChanged(Editable s) {}
        @Override public void onTextChanged(CharSequence s, int start, int before, int count) {
            String amount = s.toString();

            if( !amount.equals(current )) {
                amountEditText.removeTextChangedListener(this);
                amountEditText.setText(s);
                Selection.setSelection(amountEditText.getText(), amountEditText.getText().length());
                amountEditText.addTextChangedListener(this);
            }
        }
    });

I've searched around and have not found a solution.

Please check this link. It might help you https://github.com/BlacKCaT27/CurrencyEditText — bhaumiksoni, Apr 21 '17 at 05:13

score 1 · Accepted Answer · answered Apr 24 '17 at 04:04

I identified that the issue was coming from the textView.setText() call.

The solution was to not use setText(), instead use the Editable that is provided to you in the onTextChanged callback.

I tried to use the Editable before, however i couldn't get it working with inputs such as "$12,000".

This was due to having InputFilters still attached to the Editable.

Regards, Scott.

score 0 · Answer 2 · answered Apr 21 '17 at 05:13

0

It lags because you remove and then readd your listener.

answered Apr 21 '17 at 05:13

BlackHatSamurai

23,275
22
95
156

score 0 · Answer 3 · answered Apr 21 '17 at 05:17

0

You seems to be trying to select the text inside the EditText. To do so, simply set editText.setSelectAllOnFocus(true); or android:selectAllOnFocus="true" in xml. Then remove the entire TextChangedListener from your code.

answered Apr 21 '17 at 05:17

Bertram Gilfoyle

9,899
6
42
67

score 0 · Answer 4 · answered Apr 21 '17 at 05:28

According to me it is most probably because of trying to remove (amountEditText.removeTextChangedListener(this);) and add (amountEditText.addTextChangedListener(this);) the Text Change Listener every time. I would recommend you to replace your code without those adding and removal.

Hope this helped.

Lag after setting text in OnTextChanged()

4 Answers4