Save model with @transaction.atomic in class based view

Question

I am trying to handle both add new and edit object. My views.py file is like-

personal_data=Personal.objects.create(emp_fname=first_name, emp_mname=middle_name, emp_lname=last_name)
# rest of object is created here
try: 
    print "pk", pk
    with transaction.atomic(): 
        if pk != None:
            print "hey"
            #save model goes here
            messages.add_message(request, messages.INFO, 'Data updated successfully')
        else:
            print "hello"
            personal_data.save()
            family_data.save()
            address_data.save()
            education_data.save()
            pre_company_data.save()
            messages.add_message(request, messages.INFO, 'Data saved successfully')
except IntegrityError: 
    handle_exception()

if-else condition works properly but data is saved in both cases. even if I commented the code shown above still data goes to database.

FYI, replace `if pk != None:` with `if pk is not None`. – nik_m Apr 15 '17 at 06:36 — nik_m, Apr 15 '17 at 06:36
@nik_m no difference at all :) – V.Khakhil Apr 15 '17 at 06:51 — V.Khakhil, Apr 15 '17 at 06:51

score 1 · Accepted Answer · answered Apr 19 '17 at 09:05

If you mean that personal_data is saved in both cases, it is because you're calling Personal.objects.create, which creates and saves the model in the database in one step (reference: https://docs.djangoproject.com/en/dev/topics/db/queries/#creating-objects). If you want to separate the creation from the save, create the model using the usual constructor:

personal_data = Personal(emp_fname=first_name, emp_mname=middle_name, emp_lname=last_name)

try:
    with transaction.atomic(): 
    if pk != None:
        # do stuff
    else:
        personal_data.save()
        # do some other stuff
except IntegrityError: 
    handle_exception()

In this case, the personal_data model will be saved only in the else branch.

how to create object using filter and update that like you suggest ?? — V.Khakhil, Apr 22 '17 at 06:32

Save model with @transaction.atomic in class based view

1 Answers1