React-Router v4 onEnter replacement

Question

I'm currently trying to build a simple react-redux app that has student and campus data in the backend. OnEnter used to work here, but it doesn't exist in the new react-router.

This app tries to load initial data at the start instead of doing a componentDidMount in each actual component. Is that the recommended approach, or are there alternative patterns that I'm not aware of?

/* -------------------<    COMPONENT   >------------------- */
import React from 'react';

import { BrowserRouter as Router, Route } from 'react-router-dom';
import Home from './components/Home';
import Students from './components/Students';

const Routes = ({ getInitialData }) => {
  return (
    <Router>
      <div>
        <Route exact path="/" component={Home} onEnter={getInitialData} />
        <Route path="/students" component={Students} />
        <Route path="*" component={Home} />
      </div>
    </Router>
  );
};

/* -------------------<   CONTAINER   >-------------------- */

import { connect } from 'react-redux';
import receiveStudents from './reducers/student';
import receiveCampuses from './reducers/campus';

const mapState = null;
const mapDispatch = dispatch => ({
  getInitialData: () => {
    dispatch(receiveStudents());
    dispatch(receiveCampuses());
  }
});

export default connect(mapState, mapDispatch)(Routes);

score 23 · Accepted Answer · answered Apr 13 '17 at 11:04

23

My current solution is to put extra code in render function and not to use component property.

<Route exact path="/" render={() => {
    getInitialData();
    return <Home />;
} } />

answered Apr 13 '17 at 11:04

akmed0zmey

553
6
14

6

The problem here is that if `getInitialData` is async, `` will render before it's done fetching. Not complaining to you, this is a fault of the v4 implementation. – Brandon Aaskov Jun 15 '17 at 21:41
2

In my applications I use some flag to show that data is loading and check it in the component. During loading process indicator is showing so it's not so bad for me – akmed0zmey Jun 16 '17 at 12:56

score 15 · Answer 2 · edited May 19 '20 at 10:34

15

I want to suggest a bit different approach. Using class inheritance you can implement your own router.

import React from 'react';
import {Redirect, Route} from 'react-router';

/**
 * Class representing a route that checks if user is logged in.
 * @extends Route
 */
class AuthRequiredRoute extends Route{
  /**
   * @example <AuthRequiredRoute path="/" component={Products}>
   */
    render() {
        // call some method/function that will validate if user is logged in
        if(!loggedIn()){
            return <Redirect to="/login"></Redirect>
        }else{
          return <this.props.component />
        }
    }
}

edited May 19 '20 at 10:34

sasklacz

3,610
10
39
58

answered Aug 10 '17 at 13:09

wolendranh

4,202
1
28
37

Nice solution! But I had also to add `import React from 'react';` at the top. – phse Nov 26 '17 at 11:27
Great solution! – Tate Thurston Dec 06 '17 at 05:15
1

return is not valid in tsx. JSX element type 'this.props.component' does not have any construct or call signatures. – makeitmorehuman Feb 12 '18 at 19:12

score 11 · Answer 3 · edited Oct 26 '20 at 13:32

11

One solution is to use HOC

function preCondition(condition, WrappedComponent) {
   return class extends Component {
     componentWillMount() {
       condition()
     }

      render() {
        <WrappedComponent {...this.props} />
      }
    }
}

<Route exact path="/" component={preCondition(getInitialData, Home )} />

edited Oct 26 '20 at 13:32

Marty

2,965
4
30
45

answered Jul 18 '17 at 09:51

Daniel Dai

1,019
11
24

I really like your solution! Did you find any downside so far? Seems perfect – Thiago C. S Ventura Oct 25 '17 at 15:56
1

Can v do async calls here? – Pruthvi P Feb 08 '18 at 07:12

score 1 · Answer 4 · answered Jun 08 '18 at 08:13

import React, { Component } from 'react';
import { Route, Redirect } from 'react-router-dom';

class LoginRoute extends Component{
    render() {
        const isLogin = () => {
            if () {
                return true;
            }
            return false;
        }
        if(!isLogin()){
            return <Redirect to="/login"></Redirect>
        }else{
            return <Route path={this.props.path} exact component={this.props.component} />
        }
    }
}

export default LoginRoute;

@wolendranh thanks, it work for me! but this.props.history is undefined in component, so I change the code before — captain, Jun 08 '18 at 08:19

React-Router v4 onEnter replacement

4 Answers4