Is it possible to call a function by onclick with arguments in embedded style javascript in html?

Asked Apr 02 '17 at 12:48

Active Apr 02 '17 at 16:11

Viewed 22 times

I'm trying to call the setVideo() function on click event. But when it is embedded in html, it gets executed right away because of the brackets. Is inline-style the only way to do it?

<script>
window.onload = rv_clicked;
function rv_clicked() {
    var v_links = document.querySelectorAll("#recommendation img");
    for (var i = 0; i < v_links.length; i++) {
        // this gets executed right away:
        v_links[i].onclick = setVideo(v_links[i].title); 
    }
}
</script>

edited Apr 02 '17 at 16:11

Al.G.

4,327
6
31
56

asked Apr 02 '17 at 12:48

Herman Tam

Is there any reason you are not using EventListener ? Also Please make your question more clear; where are you calling rv_clicked function()? – Gaurav Chaudhary Apr 02 '17 at 12:53
whether it is embedded in html or it is a different script file, the behavior of javascript is same. Post complete thing you are doing. – Gaurav Chaudhary Apr 02 '17 at 12:55
When the page is loaded, the function is called. – Herman Tam Apr 02 '17 at 12:56
In general, if you want to call a function with arguments when an object is clicked. Is it possible to do it in embedded style? – Herman Tam Apr 02 '17 at 12:58
1

`something.onevent = function(evt) {doSomething(evt,arg1,arg2);}`... – Niet the Dark Absol Apr 02 '17 at 12:58
Alternatively, in this case, begin your `setVideo` function with `var title = this.title;` since `this` will refer to the element that fired the event, and just use `v_links[i].onclick = setVideo;`. – Niet the Dark Absol Apr 02 '17 at 12:59
But when if the setVideo() function is very long and it is also used by others? – Herman Tam Apr 02 '17 at 13:00
Oh, I think I can do this.title inside the setVideo() function. – Herman Tam Apr 02 '17 at 13:02
The problem is what if I don't want to refer to the title of the element that fires the event but the title of something else like its inner element. I am facing another problem now. – Herman Tam Apr 02 '17 at 13:29
try to write like this, but doesn't seem to work v_links[i].onclick = function () { setVideo(v_links[i].querySelector("img").title);}; – Herman Tam Apr 02 '17 at 13:32
The reason I am doing this is because I want the area to be clicked larger and I want to check the title of its inner element. – Herman Tam Apr 02 '17 at 13:35

Is it possible to call a function by onclick with arguments in embedded style javascript in html?

0 Answers0