websocket-sharp server sending duplicate messages

Question

Here is the rumpus.

I am building a networked app using websocket-sharp and I have run into an issue where the server sends hundreds (not consistently the same amount) of duplicate messages to the client, heres the breakdown.

1.) The client connects (This handshake works fine).

2.) Upon client connection the server sends said client the session ID created for that connection. (This works)

3.) The client receives and stores the session ID. (This works and no duplicates are sent here)

4.) The client sends a request to the lobby system on the server to create a match. (This works and is received correctly)

5.) The server receives the match creation requests, creates the match and sends the match data back to the client (One message is actually sent but the client receives hundreds of the same message (all messages are the same size and contain the same info)).

I have reviewed my lobby system logic and there is no loop that could be sending the match creation reply multiple times, furthermore I know that the "Send" method on the server is only being called once.

I have looked through the websocket-sharp documentation, I thought maybe somehow there were hundreds of sessions being made from one connection or some non-sense along those lines but I am connecting one client and only one session exits :/

Let me know if you have any ideas how this could be happening. Thanks in advance.

See below for code.

Server:

Send Method:

public void Send (string path, string targetID, string script, string method, params object[] data) {
    print ("SERVER: Sending Message");
    WebSocketServiceHost host = null;
    GetSocketServer ().WebSocketServices.TryGetServiceHost (path, out host);
    if (host != null) {
        Network.Packet packet = new Network.Packet ("Server", targetID, script, method, data);
        if (targetID != "Broadcast") {
            GetSocketServer ().WebSocketServices.Broadcast (Formatter.singleton.Serialize (packet));
        } else if (targetID == "Service") {
            host.Sessions.Broadcast (Formatter.singleton.Serialize (packet));
        } else {
            host.Sessions.SendToAsync (Formatter.singleton.Serialize (packet), targetID);
        }
    }
}

Client:

Receive Methods:

GetPersistent ().OnMessage += MessageHandler;

void MessageHandler (object sender, MessageEventArgs e) {
    Debug.Log ("CLIENT: Message Recieved");
    Network.singleton.Recieve (e.RawData);
}

Network: (Used by both Server and Client)

Receive Methods:

public void Recieve (byte[] data) {
    object obj = Formatter.singleton.Deserialize (data);
    messages.Add (messages.Count, obj);
}

IEnumerator ProcessorCoro () {
    WaitForSeconds delay = new WaitForSeconds (Time.deltaTime);
    while (true) {
        if (messages.Count >= 1) {
            Process (messages [(messages.Count - 1)]);
            messages.Remove ((messages.Count - 1));
        } 
        yield return delay;
    }
}

public void Process (object data) {
    Network.Packet packet = (Network.Packet)data;
    switch (packet.script) {
    case "Home":
        Home.singleton.SendMessage (packet.method, data, SendMessageOptions.DontRequireReceiver);
        break;
    case "Arena":
        Arena.singleton.SendMessage (packet.method, data, SendMessageOptions.DontRequireReceiver);
        break;
    case "Client":
        Client.singleton.SendMessage (packet.method, data, SendMessageOptions.DontRequireReceiver);
        break;
    case "Database":
        Database.singleton.SendMessage (packet.method, data, SendMessageOptions.DontRequireReceiver);
        break;
    }
}

By saying ` receives hundreds of the same message`, do you mean MessageHandler() is called hundreds of times and so Process() is called hundreds of times or just Process() is called hundreds of times? — Chong, Mar 30 '17 at 23:17
MessageHandler is called. It prints the debug.log to the console. — Sean Barnard, Apr 01 '17 at 01:36
I am pretty confused about the `GetPersistent()` in your code. I didn't find this function in Unity's library nor websocket-sharp's source code. Is this a function you wrote to build a connection with your web-socket on your server? — Chong, Apr 01 '17 at 21:05
@Chong Yes you can establish multiple connections per client, in my case I had a temporary and persistent connection. That call was just to delegate an event to that connection. That part is working, if it wasn't than I would not be processing the com at all. — Sean Barnard, May 14 '17 at 03:02

score 0 · Answer 1 · answered Nov 30 '18 at 13:55

At the client side, you need to ensure that you call the following line only once

GetPersistent ().OnMessage += MessageHandler;

Otherwise, you would be registering the same handler multiple times to the message reception.

Note: This behavior could be desired in case you want to attach multiple handlers to the same OnMessage event.

websocket-sharp server sending duplicate messages

1 Answers1