Is this a legal if sentance?

Question

I just started coding and can't get this "Heater" object to work. It just prompts the if else statement "its too hot" when trying to give temp a higher value and it does not stop/ goes below the min temp value when calling the "colder" method. Thanks

public class Heater {
    private double temp;
    private double min;
    private double max;
    private double increment;

    public Heater(double min, double max) {
        temp = 15;
        increment = 5;
    }

    public void Warmer() {
        if(temp + increment <= max) {
            temp = temp + increment;
        } else if(temp + increment > max) {
            System.out.println("Too hot");
        }
    }

    public void Colder() {
        if(temp - increment >= min){
            temp = temp - increment;
        } else if (temp - increment < min){
            System.out.println("Too cold");
        }
    }

    public double getTemp() {
        return temp;
    }
}

score 0 · Accepted Answer · answered Mar 30 '17 at 14:22

0

You're not setting min and max in your constructor, so they stay at 0 by default. Try this:

public Heater(double min, double max) {
    this.min = min;
    this.max = max;
    temp = 15;
    increment = 5;
}

answered Mar 30 '17 at 14:22

Michael Dodd

10,102
12
51
64

Also, consider some test cases. What if someone sets `min` greater than `max`? – Michael Dodd Mar 30 '17 at 14:24

score 0 · Answer 2 · edited Mar 30 '17 at 15:07

0

You are using Caps for method names. Caps are for Class names.
You aren't setting min. It's at a value of zero.
You don't need the else if condition - just use else instead.

 public void colder() { // method name, make lower case.
    if(temp - increment >= min){
       temp = temp - increment;
    } else {
       System.out.println("Too cold");
    }
  }

edited Mar 30 '17 at 15:07

Michael Dodd

10,102
12
51
64

answered Mar 30 '17 at 14:26

Dakoda

175
7

Oh, @Michael Dodd beat me to it. – Dakoda Mar 30 '17 at 14:26
You still need the `else` keyword. In that example it will always print `Too Cold` – Michael Dodd Mar 30 '17 at 14:28
Thanks, You're correct, I was too quick to comment the line. I meant to comment between the else and if. – Dakoda Mar 30 '17 at 14:45

Is this a legal if sentance?

2 Answers2