Best practice for default function values in PHP using const values in classes

Question

PhpStorm is highlighting $requestType in the following piece of code in red, which I don't understand why. Maybe a bug in PhpStorm? Maybe is just not a good practice to define like that default function values?

class HttpClient
{
    const RequestTypes = [
        'DEFAULT' => 'default',
        'JSON' => 'json'
    ];

    public function makeRequest(
        string $requestType = self::RequestTypes['DEFAULT']
    ): Response {

        // The function

    }
}

The error message is Default value for parameters with string type can only be string or NULL.

Obviously the ['DEFAULT'] value is a string, but still giving an error.

What do you think?

Well, thats a drastic solution, but it didn't work, is till highlighting it. Thanks anyway, now I'm using the latest version \o/ — Alberto Roura, Mar 23 '17 at 01:14
Do you get any warnings if you run `php -l` against the file? I *think* that will use PHP's built-in linter. Some other editors/IDEs use that as the base of their PHP checking. — Nathan Craike, Mar 23 '17 at 01:21
Thanks for it, I ran `php -l` and gave 0 syntax errors. So I start thinking is a bug in PhpStorm... — Alberto Roura, Mar 23 '17 at 01:32
I think it is this PhpStorm bug here: https://youtrack.jetbrains.com/issue/WI-35313 — Nathan Craike, Mar 23 '17 at 03:35
Thats it. You found it. Is what is exactly happening. Thanks! — Alberto Roura, Mar 23 '17 at 03:38

score 2 · Answer 1 · edited May 23 '17 at 11:46

2

As commented by Nathan, this seems like an existing PhpStorm bug already reported at Wrong evaluation of type. Thanks!

edited May 23 '17 at 11:46

Community

1
1

answered Mar 23 '17 at 03:42

Alberto Roura

41
5

The question may get closed as "invalid" or similar, since your code *is* best practice, it's just the bug in PHP Storm marking it as an error. – Nathan Craike Mar 23 '17 at 05:30
I've flagged the question to be closed. Not 100% sure I chose the correct reasons, but… I don't think it's suitable for Stack Overflow now that we've found it in the PHP Storm issue tracker. – Nathan Craike Mar 23 '17 at 05:35

Best practice for default function values in PHP using const values in classes

1 Answers1