App crashes after button press

Question

When I'm debugging my app all works, but when I build APK (Debug, release, signed..) it crashes after I press the button.

My onClick method:

protected void Click(View V) {
    Toast.makeText(this, "Hi!", Toast.LENGTH_SHORT).show();
}

Button XML:

<Button
    android:id="@+id/btnSpy"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_centerHorizontal="true"
    android:layout_centerVertical="true"
    android:onClick="Click"
    android:text="Activate"
    android:textAllCaps="false"
    tools:layout_editor_absoluteX="148dp"
    tools:layout_editor_absoluteY="212dp" />

EDIT: Sorry forgot to change Spy to Click

A stacktrace from the crash might be useful. In short there isn't enough info here to help you. — tantalum, Mar 22 '17 at 21:49
Compare your method names in xml and in Java. And, yes, please post stacktraces from your crashes when you need help. — codeMagic, Mar 22 '17 at 21:55

score 0 · Accepted Answer · 2017-03-23T00:58:20.543

0

Simply change protected to public and change onClick="Spy" to onClick="Click"

edited Mar 23 '17 at 00:58

answered Mar 22 '17 at 21:52

Just mark it as accepted if it works for you – Mar 22 '17 at 22:08
How does this solve the problem? – codeMagic Mar 22 '17 at 22:10
Method referenced in xml onClick must be public – Mar 22 '17 at 22:11
And this will fix it? – codeMagic Mar 22 '17 at 22:14
Yes. My students have made this mistake several times. And Yes, it fixes it. Try it out... – Mar 22 '17 at 22:16
I think you're missing something... – codeMagic Mar 22 '17 at 22:26
And what would that be? – Mar 22 '17 at 22:29
2

The method name – codeMagic Mar 22 '17 at 22:32
Ouch! I didn't see that. Thanks for pointing that out, updated my answer. – Mar 23 '17 at 00:59

App crashes after button press

1 Answers1