'make_pair' cannot be used as a function

Question

This is my complete code:

  #include <iostream>
#include <vector>
#include <bits/stdc++.h> 

using namespace std;
#define ff first
#define mp make_pair

#define ss second


int main(void) {

    int m;
    vector <string> grid;

    cin >> m;

    pair <int,int> foo;
 pair <int,int> bar;


// bar =make_pair (10.5,'A');
foo = make_pair (1,2);
cout<<foo.ss<<endl;
    for(int i=0; i<m; i++) {
        string s; cin >> s;
        grid.push_back(s);
        int pp = s.find('p');
        int mp = s.find('m');
        if(pp>=0){
          bar = make_pair(pp,i);
        }
      cout<<pp<<endl;
    }
    return 0;
}

This is my error:

prog.cpp: In function 'int main()':
prog.cpp:40:32: error: 'make_pair' cannot be used as a function
            bar = make_pair(pp,i);
                                ^

make_pair gives this error when I placed it inside the for loop, it works completely fine if I place it out. Where am I going wrong?

Edit: I amtrying in codechef ide...these are the inputs

3
---
-m-
p--

Didn't you just ask this? You could have just edited and reopened your question. — Kerrek SB, Mar 21 '17 at 19:15
Sorry for deleting, I thought the question would be removed looking at the amount of downvotes. — MrRobot9, Mar 21 '17 at 19:23
Well, if you fix the question, there's a good chance people will undownvote... — Kerrek SB, Mar 21 '17 at 19:24
Hey, that's what we call a "moving goalpost" question... best not to do that, people may rapidly feel that you're wasting their attention. — Kerrek SB, Mar 21 '17 at 19:25
isn't macro definition a good practice,I have seen these a lot in coding contests, so I have been using it. — MrRobot9, Mar 21 '17 at 19:27
@MrRobot9 Doesn't the very existence of this question answer that one? — Barry, Mar 21 '17 at 19:28
"isn't macro definition a good practice" -- No. In C? Maybe, sometimes, it depends. In C++? Almost never. "I have seen these a lot in coding contests, so I have been using it." -- What was the goal of those coding contests? It probably wasn't to create readable re-usable code. — , Mar 21 '17 at 19:29
Please don't fix code in your question after the issues have been pointed out. — Barry, Mar 21 '17 at 19:40

score 8 · Accepted Answer · answered Mar 21 '17 at 19:23

8

#define mp make_pair
...
    int mp = s.find('m');
...
      bar = make_pair(pp,i);

You declared make_pair as a variable, hiding the function.

To fix this, get rid of your horrible macro definition.

answered Mar 21 '17 at 19:23

1

yeah but it was giving output when placed outside the for loop, so I was confused. – MrRobot9 Mar 21 '17 at 19:45
1

@MrRobot9 It's not "outside the for loop" where it works, it's "outside the variable's scope". For instance, inside the loop but before the variable definition, it would also work. – Mar 21 '17 at 19:52

'make_pair' cannot be used as a function

1 Answers1