0

After spending a few years locked into an ancient tech stack for a project, I'm finally getting a chance to explore more current frameworks and dip a toe into React and Webpack. So far, it's for the most part been a refreshing and enjoyable experience, but I've run across some difficulty with Webpack that I'm hoping the hive-mind can help resolve.

I've been poring over the Webpack 2.0 docs and have searched SO pretty exhaustively, and come up short (I've only turned up this question, which is close, but I'm not sure it applies). This lack of information out there makes me think that I'm looking at one of two scenarios:

  1. What I'm trying to do is insane.
  2. What I'm trying to do is elementary to the point that it should be a no-brainer.

...and yet, here I am.

The short version of what I'm looking for is a way to exclude certain JSX components from being included in the Webpack build/bundle, based on environment variables. At present, regardless of what the dependency tree should look like based on what's being imported from the entry js forward, Webpack appears to be wanting to bundle everything in the project folder.

I kind of assume this is default behavior, because it makes some sense -- an application may need components in states other than the initial state. In this case, though, our 'application' is completely stateless.

To give some background, here are some cursory requirements for the project:

  • Project contains a bucket of components which can be assembled into a page and given a theme based on a config file.
  • Each of these components contains its own modular CSS, written in SASS.
  • Each exported page is static, and the bundle actually gets removed from the export directory. (Yes, React is a bit of overkill if the project ends at simply rendering a series of single, static, pages. A future state of the project will include a UI on top of this for which React should be a pretty good fit, however -- so best to have these components written in JSX now.)
  • CSS is pulled from the bundle using extract-text-webpack-plugin - no styles are inlined directly on elements in the final export, and this is not a requirement that can change.
  • As part of the page theme information, SASS variables are set which are then used by the SASS for each of the JSX components.
  • Only SASS variables for the JSX components referenced in a given page's config file are compiled and passed through sass-loader for use when compiling the CSS.

Here's where things break down:

Let's say I have 5 JSX components, conveniently titled component_1, component_2, component_3, and so on. Each of these has a matching .scss file with which it is associated, included in the following manner:

import React from 'react';
import styles from './styles.scss';

module.exports = React.createClass({

  propTypes: {
    foo: React.PropTypes.string.isRequired,
  },

  render: function () {

    return (
      <section className={`myClass`}>
        <Stuff {...props} />
      </section>
    );
  },
});

Now let's say that we have two pages:

  • page_1 contains component_1 and component_2
  • page_2 contains component_3, component_4, and component_5

These pages both are built using a common layout component that decides which blocks to use in a manner like this:

return (
  <html lang='en'>
    <body>
      {this.props.components.map((object, i) => {
        const Block = component_templates[object.component_name];
        return <Block key={i}{...PAGE_DATA.components[i]} />;
      })}
    </body>
  </html>
);

The above iterates through an object containing my required JSX components (for a given page), which is for now created in the following manner:

load_components() {
  let component_templates = {};
  let get_component = function(component_name) {
    return require(`../path/to/components/${component_name}/template.jsx`);
  }
  for (let i = 0; i < this.included_components.length; i++) {
    let component = this.included_components[i];
    component_templates[component] = get_component(component);
  }
  return component_templates;
}

So the general flow is:

  1. Collect a list of included components from the page config.
  2. Create an object that performs a require for each such component, and stores the result using the component name as a key.
  3. Step through this object and include each of these JSX components into the layout.

So, if I just follow the dependency tree, this should all work fine. However, Webpack is attempting to include all of our components, regardless of what the layout is actually loading. Due to the fact that I'm only loading SASS variables for the components that are actually used on a page, this leads to Webpack throwing undefined variable errors when the sass-loader attempts to process the SASS files associated with the unused modules.

Something to note here: The static page renders just fine, and even works in Webpack's dev server... I just get a load of errors and Webpack throws a fit.

My initial thought is that the solution for this is to be found in the configuration for the loader I'm using for the JSX files, and maybe I just needed to tell the loader what not to load, if Webpack was trying to load everything. I'm using `babel-loader for that:

{ test: /\.jsx?$/,
  loader: 'babel-loader',
  exclude: [
    './path/to/components/component_1/',
  ],
  query: { presets: ['es2015', 'react'] } 
},

The exclude entry there is new, and does not appear to work.

So that's kind of a novella, but I wanted to err on the side of too much information, as opposed to being scant. Am I missing something simple, or trying to do something crazy? Both?

How can I get unused components to not be processed by Webpack?

Community
  • 1
  • 1
dhezl
  • 3
  • 2

1 Answers1

0

TL;DR

Don't use an expression in require and use multiple entry points, one for each page.


Detailed answer

Webpack appears to be wanting to bundle everything in the project folder.

That is not the case, webpack only includes what you import, which is determined statically. In fact many people that are new to webpack are confused at first that webpack doesn't just include the entire project. But in your case you have hit kind of an edge case. The problem lies in the way you're using require, specifically this function:

let get_component = function(component_name) {
  return require(`../path/to/components/${component_name}/template.jsx`);
}

You're trying to import a component based on the argument to the function. How is webpack supposed to know at compile time which components should be included? Well, webpack doesn't do any program flow analysis, and therefore the only possibility is to include all possible components that match the expression.

You're sort of lucky that webpack allows you to do that in the first place, because passing just a variable to require will fail. For example:

function requireExpression(component) {
  return require(component);
}

requireExpression('./components/a/template.jsx');

Will give you this warning at compile time even though it is easy to see what component should be required (and later fails at run-time):

Critical dependency: the request of a dependency is an expression

But because webpack doesn't do program flow analysis it doesn't see that, and even if it did, you could potentially use that function anywhere even with user input and that's essentially a lost cause.

For more details see require with expression of the official docs.

Webpack is attempting to include all of our components, regardless of what the layout is actually loading.

Now that you know why webpack requires all the components, it's also important to understand why your idea is not going to work out, and frankly, overly complicated.

If I understood you correctly, you have a multi page application where each page should get a separate bundle, which only contains the necessary components. But what you're really doing is using only the needed components at run-time, so technically you have a bundle with all the pages in it but you're only using one of them, which would be perfectly fine for a single page application (SPA). And somehow you want webpack to know which one you're using, which it could only know by running it, so it definitely can't know that at compile time.

The root of the problem is that you're making a decision at run-time (in the execution of the program), instead this should be done at compile time. The solution is to use multiple entry points as shown in Entry Points - Multi Page Application. All you need to do is create each page individually and import what you actually need for it, no fancy dynamic imports. So you need to configure webpack that each entry point is a standalone bundle/page and it will generate them with their associated name (see also output.filename):

entry: {
  pageOne: './src/pageOne.jsx',
  pageTwo: './src/pageTwo.jsx',
  // ...
},
output: {
  filename: '[name].bundle.js'
}

It's that simple, and it even makes the build process easier, as it automatically generates pageOne.bundle.js, pageTwo.bundle.js and so on.


As a final remark: Try not to be too smart with dynamic imports (pretty much avoid using expressions in imports completely), but if you decide to make a single page application and you only want to load what's necessary for the current page you should read Code Splitting - Using import() and Code Splitting - Using require.ensure, and use something like react-router.

Michael Jungo
  • 31,583
  • 3
  • 91
  • 84
  • Excellent, this is exactly what I was looking for -- and thanks for pointing me to the right spot in the docs, I was totally looking in the wrong spot with resolvers. Quick question: If, for some reason, discrete entry points are problematic (say, due to scalability),is this something that could also be solved with `require.context`? – dhezl Mar 14 '17 at 19:54
  • Maybe, it depends on what exactly you want do, but there might also be better solutions. – Michael Jungo Mar 14 '17 at 20:08
  • Eventually, I want to have a user create pages using existing layouts that they can drop components into, and export a static page...with the entire page being defined by a JSON object that can simply be fed into the flow to generate the page. At that point, the application will have one entry that includes all components and a nifty UI. So maybe it's not _so_ bad that everything is being bundled, and I should just open up the throttling of my SASS variables and call it a day... – dhezl Mar 14 '17 at 20:13
  • I'd personally just generate a `jsx` file based on the JSON configuration, which serves as the entry point, and just run webpack on it (preferably with the Node API). Your UI would be totally separate from that (a different app altogether), so if you want to showcase the components they will all end up in that app. – Michael Jungo Mar 14 '17 at 20:29