angular factory store promise result

Question

I have a factory object that contain private object, which is used to cache result retrieved from the api using the factory available functions.

global.mainApp.factory('SessionFactory', function (UserEndpointsResource, SiteEndpointsResource) {
    var data = {
        /**
         * @type {boolean|null}
         */
        isLoggedIn: null
    };
    return {
        isUserLoggedIn: function (callback) {
            if (data.isLoggedIn != null) {
                callback(data.isLoggedIn);
            }
            else {
                UserEndpointsResource.isLoggedIn().$promise.then(function (res) {
                    var isUserLoggedIn = res.status == 1;
                    // Trying to set the result to the outer scope data variable
                    data.isLoggedIn = isUserLoggedIn;
                    callback(isUserLoggedIn);
                }, function (failureData) {
                    data.isLoggedIn = false;
                    callback(false);
                });
            }
        },
        ...
    };
});

The problem that every time I call the isUserLoggedIn function, data.isLoggedIn is always null.

How can I alter the factory data object inside the promise then function?

Thanks.

Any chance you are instantiating multiple `SessionFactory`s? — Bergi, Mar 08 '17 at 21:10
Protip: [do not store promise results, store promises themselves](http://stackoverflow.com/q/18744830/1048572) — Bergi, Mar 08 '17 at 21:12
Did you check that your code is getting to `data.isLoggedIn = isUserLoggedIn;`? — Castro Roy, Mar 08 '17 at 21:12

score 0 · Accepted Answer · edited May 23 '17 at 12:25

Using the suggestion supplied in the comments, aka do not store promise results, store promises themselves, this is the modified working code!

global.mainApp.factory('SessionFactory', function (UserEndpointsResource, SiteEndpointsResource) {
    var data = {
        /**
         * @type {boolean|null}
         */
        isLoggedIn: null
    };
    return {
        isUserLoggedIn: function (callback) {
            if (data.isLoggedIn != null) {
                data.isLoggedIn.then(function (isLoggedIn) {
                    callback(isLoggedIn.status == 1);
                });
            }
            else {
                data.isLoggedIn = UserEndpointsResource.isLoggedIn().$promise.then(function (res) {
                    var isUserLoggedIn = res.status == 1;
                    callback(isUserLoggedIn);
                    return isUserLoggedIn;
                }, function (failureData) {
                    data.isLoggedIn = false;
                    callback(false);
                    return null;
                });
            }
        }
    };
});

angular factory store promise result

1 Answers1