substring causing Index and length must refer to a location within the string error?

Question

I am trying to log errors that may happened within my application and insert it into oracle database as below, but I am getting error at substring that says

Index and length must refer to a location within the string.

catch (Exception EX)
{
    string ErrorMsg = EX.Message.Substring(1, 1024);

    Error_log(ErrorMsg, null, "InsertProductData", "F0103", null);
    MessageBox.Show("Please call technical support", "ُError Message", MessageBoxButtons.OK, MessageBoxIcon.Error);
}

anyone can help please ? is there more infroamtion I can save too ? anyway to extract error code ? not only the error message ?

Sutloion Feedback

Thank you all .. just want to give feedback for other on how solved issue like this I solved by using below code

string ErrorMsg = ex.Message.Substring(0, Math.Min(ex.Message.Length, 1024));

@imsome1 I just want the first 1024 character which is the maximum size of column so I am string the substring from position zero to 1024 — sam, Mar 06 '17 at 18:00
There are many cases in programming where the error messages that we receive are cryptic and we have no option but go to stackoverflow for help. This isn't one of them. — Mike Nakis, Mar 06 '17 at 18:05

score 1 · Accepted Answer · answered Mar 06 '17 at 18:09

1

change EX.Message.Substring(1, 1024) to EX.Message.Substring(1,Math.Min(Ex.Message.Length - 1,1024))

answered Mar 06 '17 at 18:09

levent

3,464
1
12
22

Why not include the 0th `char`? – Jeppe Stig Nielsen Mar 06 '17 at 18:12
There is no special reason. he started from 1 – levent Mar 06 '17 at 18:15
@levent NO exception no error and nothing happend – sam Mar 06 '17 at 20:08

substring causing Index and length must refer to a location within the string error?

1 Answers1