How can I call callback function in async.eachSeries callback function

Question

I'm trying to call callback function after eachSeries is done, but IT doesn't work at all. It doesn't print 2 that's supposed to print when It's called but It prints 4 after first function is called. Is there any idea about it? Thank you!

async.waterfall([
      function(callback) {
        console.log("1");
        let eroJson = [];
        rp(optForReddit).then(function(redditJSON) {
          let posts = redditJSON.data.children;
          async.eachSeries(posts, function(item, callback) {
            if (isVideo(item.data.url)) {
              eroJson.push(getAlbumId(item.data.url));
            }
            callback(); // callback function after eachSeries
          }, function() {
            callback(eroJson); // call next callback
          });
        })
      },
      function(redditJSON, callback) {
        console.log("2");
        callback() // call another function
      }
)],
     function(){
         console.log("Last one");
     }

);

@JaromandaX This is a part of code. I just simplified the code that's why it doesn't seem to call call callback in second function. but second function should run `console.log` line anyways — boombamboo, Feb 12 '17 at 09:16
@AsifSaeed getAlbum function is this short code. `function getAlbumId(str) { return str.split('/')[3]; }` — boombamboo, Feb 12 '17 at 09:24

Asif Saeed · Accepted Answer · 2017-02-12T09:16:06.563

0

Change the callback names. it seems like you are overriding callback Names

    async.waterfall([
          function(waterfallCallback) {
            console.log("1");
            let eroJson = [];
            rp(optForReddit).then(function(redditJSON) {
              let posts = redditJSON.data.children;
              async.eachSeries(posts, function(item, callback) {
                if (isVideo(item.data.url)) {
                  eroJson.push(getAlbumId(item.data.url));
                }
                callback(); // callback function after eachSeries
              }, function() {
                waterfallCallback(eroJson); // call next callback
              });
            })
          },
          function(redditJSON, waterfallCallback) {
            console.log("2");
            waterfallCallback();
          }
    )], function(){
            console.log("Done executing all waterfall functions");
    });

edited Feb 12 '17 at 09:16

answered Feb 12 '17 at 09:10

Asif Saeed

1,985
14
24

http://pastebin.com/cXjAZR3w here's the full code for you. after I changed named all the callback functions to waterfallCallback, It still doesn't work. `1 4` Is what I got after run the code. – boombamboo Feb 12 '17 at 09:23
function 2 and 3 in your waterfallchain not even called. and the final callback of waterfall will only invoke when all the functions call there callbacks – Asif Saeed Feb 12 '17 at 09:37
whare are your redditJSON and optForEroshare defined? – Asif Saeed Feb 12 '17 at 09:40
what do you mean? I can see they are called – boombamboo Feb 12 '17 at 09:42
redditJSON is what I got after run `request-promise(rp)` and optForEroshare is defined in function 2 – boombamboo Feb 12 '17 at 09:44
ok i got the problem. use waterFallcallback(null, eroJson); instead of waterFallcallback(eroJson); – Asif Saeed Feb 12 '17 at 09:47
in your second function Ero. is not defined anywhere so its throwing errror. take care of that aswell – Asif Saeed Feb 12 '17 at 09:48
in the second function do waterFallcallback(null, optForEroshare); instead of waterFallcallback(optForEroshare); – Asif Saeed Feb 12 '17 at 09:49
https://coderwall.com/p/zpjrra/async-waterfall-in-nodejs check this a better way of writing async.waterfall – Asif Saeed Feb 12 '17 at 09:50
1

oh my god you are awesome.. I wanna give you a million reputation – boombamboo Feb 12 '17 at 09:56

How can I call callback function in async.eachSeries callback function

1 Answers1