Shell:nested for loop

Question

Somehow in the following script, value of $i
is not expanded on line 3. Any idea why?

for i in `cat test.txt`
do
        for j in `find . -name $i`
        do
                echo $j
        done
done

@dharm0us - what is inside "test.txt" ? if find does not return any matches, simply quote it `for j in `find . -name "*$i*"` — ajreal, Nov 15 '10 at 09:01
@dharm0us: Are you sure that the problem is the expansion? I tried it and it worked correctly. Put that script in a file and add `#!/bin/bash -x` at the top of it to see what's going on. — Alberto Zaccagni, Nov 15 '10 at 09:29
@ajreal - test.txt has file names, one name per line. find does return matches for the file names, when executed on command line. — simplfuzz, Nov 15 '10 at 10:17
@Alberto : $ ./test.sh ++ cat test.txt + for i in '`cat test.txt`' ++ find . -name $'CityForest.fla\r' — simplfuzz, Nov 15 '10 at 10:20
@dharm0us - clueless, never use cygwin before, try this `cat test.txt|xargs` ? — ajreal, Nov 15 '10 at 10:30
@ajreal, yes it's something to do with cygwin. I tried the same script on a linux box, it works. — simplfuzz, Nov 15 '10 at 10:35
Ok, got it finally. I need to convert the files from dos to unix format, using d2u command. It works after that. d2u test.txt;d2u test.sh;./test.sh — simplfuzz, Nov 15 '10 at 10:39

score 2 · Answer 1 · answered Nov 15 '10 at 16:09

2

After you fix the line endings:

xargs --arg-file test.text -I % find . -name "%"

No need for nested loops.

answered Nov 15 '10 at 16:09

Dennis Williamson

score 0 · Accepted Answer · answered Nov 15 '10 at 11:01

0

for i in `cat test.txt | sed -e "s/\r//g"`; do find -name $i; done

big question: cygwin support sed?

or cygwin

d2u test.txt; for i in `cat test.txt`; do find -name $i; done

or linux

dos2unix test.txt; for i in `cat test.txt`; do find -name $i; done

answered Nov 15 '10 at 11:01

ajreal

2 Answers2