Adding some boolean conditions in pointcut expression

Question

I'm using some aspect around advice methods. I have methods for controller, service and repository.

@Around("execution(* com.abc..controller..*(..)) && @annotation(audit)")
    public Object controllerAround(ProceedingJoinPoint proceedingJoinPoint, Audit audit) throws Throwable {
        //some code here
        return output;
    }

@Around("execution(* com.abc..service.*Impl.*(..))")
    public Object serviceAround(ProceedingJoinPoint proceedingJoinPoint) throws Throwable {
        //some code here
        return output;
    }

@Around("execution(* com.abc..persistence.*Impl.*(..))")
    public Object persistenceAround(ProceedingJoinPoint proceedingJoinPoint) throws Throwable {
        //some code here
        return output;
    }

I have a query that, I need to check in serviceAround method pointcut expression that, whether it's comes from the controllerAround method. I tried using some flags, but spring doesn't support aspectj's if() pointcut primitive.

Any workaround for this will be appreciated. :)

kriegaex · Answer 1 · 2017-01-23T09:05:25.333

2

What you actually need is cflow() or cflowbelow(), not if(). But those are also not supported by Spring AOP. So the remaining solution is to use the full power of AspectJ from within Spring via LTW (load-time weaving). How this is done is nicely documented.

The pointcut would look like this:

execution(* com.abc..service.*Impl.*(..)) &&
cflow(
    execution(* com.abc..controller..*(..)) &&
    @annotation(customAnnotation)
)

Or simpler, assuming you do not need the annotation in the advice method:

execution(* com.abc..service.*Impl.*(..)) &&
cflow(execution(* com.abc..controller..*(..)))

Attention: cflow() only works for control flows within one thread, not if e.g. *Impl*.(..) is executed in another thread than controller..*(..).

P.S.: Your sample code would probably not work because of a parameter name mismatch between customAnnotation and audit.

edited Jan 23 '17 at 09:05

answered Jan 23 '17 at 08:54

kriegaex

63,017
15
111
202

Tried LTW configurations and when building the project, showing " unsupported pointcut primitive 'cflow' " error. – Abhishek Ramachandran Jan 24 '17 at 08:10
Then you did not use AspectJ LTW but Spring AOP. – kriegaex Jan 24 '17 at 08:19
Is there any other workarounds with the spring supported primitives !! – Abhishek Ramachandran Jan 24 '17 at 08:24
You do not need workarounds, you need a solution: Just use AspectJ instead of Spring AOP. Read the fine manual, please. And next time please also read my answer more carefully. – kriegaex Jan 24 '17 at 08:27

Adding some boolean conditions in pointcut expression

1 Answers1