why does changing of class of a element distorts the view?

Question

I am trying to change a class of a element and my view gets distorted? How do I solve it.

I have created the fiddle for the same Jsfiddle

Issue Description:

I have a custom textbox. I have a reference value at top left corner of it. If I enter value greater or less than the reference value , I show a box asking for reason.

It works perfectly fine, but when I try to add some extra functionality , like changing the color of the div in right top corner of textbox by changing the class of the div , the view is distorted and not as it was expected.

In the fiddle I can commented the code in javascript section at line 73,74,77,78

function changeClassOfCommentToRed(divId){
//$("#"+divId).removeClass();
//$("#"+divId).addClass("commentCornerRed");
}
function changeClassOfCommentToGreen(divId){
//$("#"+divId).removeClass();
//$("#"+divId).addClass("commentCornerGreen");
}

if I uncomment the above line for extra functionality , I get a distorted view as in following image

`` elements cannot have content. That's what the red stuff in jsfiddle is trying to tell you. — Pointy, Jan 18 '17 at 15:26
Please provide all relevant code in an [mcve] in the question itself, not on a third-party site. — Heretic Monkey, Jan 18 '17 at 15:44

Pierre Météyé · Answer 1 · 2017-01-18T15:53:01.950

1

Try to specify which class to remove in your removeClass :

removeClass('classToRemove');

edited Jan 18 '17 at 15:53

answered Jan 18 '17 at 15:32

Pierre Météyé

143
1
1
10

1

`removeClass` receives just the class name, withou the `.` selector. – Marcos Lima Jan 18 '17 at 15:48

gre_gor · Answer 2 · 2017-01-18T15:47:02.743

You only need to remove the classes you want to change:

function changeClassOfCommentToRed(divId){
    $("#"+divId).removeClass("commentCornerGreen commentCornerRed");
    $("#"+divId).addClass("commentCornerRed");
}
function changeClassOfCommentToGreen(divId){
    $("#"+divId).removeClass("commentCornerGreen commentCornerRed");
    $("#"+divId).addClass("commentCornerGreen");
}

And in your CSS you need to address your arrow pseudo element not the element itself:

.commentCornerRed:after {
    ...
}
.commentCornerGreen:after {
    ...
}

With this changes, only the color of the arrows is changed, not the color of the box.

Yonas Hailu · Answer 3 · 2017-01-18T15:41:45.057

If I get what question correctly. I think this commentCornerRed class got width: 0 and height: 0. you can have the same properties as .arrow_box

.commentCornerRed {
     position: absolute;
    width: 0;
    height: 0; 
    display: block;
    border-style: solid;
    border-width: 0 10px 10px 0;
    border-color: transparent #ff0000 transparent transparent;
    padding-left: 36px;
    cursor: pointer;
}

You can make it like this.

.commentCornerRed {
    position: absolute;
    background: #bcb476;
    border: 1px solid #08090a;
    z-index: 1;
    margin-left: 50px;
    margin-top: -40px;
}

score 0 · Answer 4 · answered Jan 18 '17 at 16:20

I made a silly mistake. I was passing the wrong id for class name. Got the desired result by passing the right id at line 85 and 87 in javascript section.

changing from

function handleCommentBox(event){
if(checkIfReasonSelected(returnIdPrefix(event)+"r1")){
    changeClassOfCommentToGreen(returnIdPrefix(event)+"r1");
    }else{
    changeClassOfCommentToRed(returnIdPrefix(event)+"r1");
    }
}

to

function handleCommentBox(event){
if(checkIfReasonSelected(returnIdPrefix(event)+"r1")){
    changeClassOfCommentToGreen(returnIdPrefix(event)+"c1");
    }else{
    changeClassOfCommentToRed(returnIdPrefix(event)+"c1");
    }
}

solved the problem. Thanks people for helping.

why does changing of class of a element distorts the view?

4 Answers4