Custom dialog not working with 'setOnClickListener' Android studio

Question

I have a bit of weird situation - I have a made a custom dialog that opens when a button from the activity is clicked. The custom dialog contains a close button that when clicked closes the dialog and returns user to the activity. When I run the code as it is (shown below), instead of launching the custom dialog, it goes to the main activity (I think either reopens the app or somehow creates a imaginary intent for the main activity). However, when I remove/comment the code for the close button - highlighted as // === this code, everything works fine (the custom dialog opens) but the close button doesn't function. I am not sure what I am missing.

    // Global variable
    Button openDialog;

    // ======
    openDialog = (Button) findViewById(R.id.opendialog);
    openDialog.setOnClickListener(new Button.OnClickListener() {
        public void onClick(View v) {

            final Dialog cusomDialog = new Dialog(sellActivity.this);
            cusomDialog.setContentView(R.layout.customdialog);


            // === This code
            final Button close = (Button) findViewById(R.id.close);
            close.setOnClickListener(new View.OnClickListener() {
                    @Override
                    public void onClick(View v) {
                        cusomDialog.dismiss();

                    }
                });
            // === This code

            cusomDialog.show();


        }
    });

Can someone please shed some light on this, as I am really confused.

also you can follow this link https://www.mkyong.com/android/android-custom-dialog-example/ — Dileep Patel, Jan 17 '17 at 10:15

score 4 · Accepted Answer · answered Jan 17 '17 at 10:13

4

Initialize your View of Dialog inside Dialog:

Replace this:

final Button close = (Button) findViewById(R.id.close);

With this:

final Button close = (Button) cusomDialog.findViewById(R.id.close);

answered Jan 17 '17 at 10:13

W4R10CK

5,502
2
19
30

IntelliJ Amiya · Answer 2 · 2017-01-17T10:22:38.407

At First, You should pass cusomDialog View Object .

Secondly , Dialog Create and call method wrong .

   final Button close = (Button)cusomDialog.findViewById(R.id.close);
        close.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    cusomDialog.dismiss();

                }
            });

Same problem

openDialog = (Button)cusomDialog.findViewById(R.id.opendialog); //Rectified

You should read Custom Dialog for more information .

score 0 · Answer 3 · answered Jan 17 '17 at 10:37

I think you should inflate the layout and get the view and set the view in your custom dialog.

final Dialog cusomDialog = new Dialog(sellActivity.this);
View view = LayoutInflater.fromContext(sellActivity.this).inflate(R.layout.customdialog,false);
cusomDialog.setContentView(view);
Button close = (Button) view.findViewById(R.id.close);

Good Luck!!

CoolMind · Answer 4 · 2022-05-30T10:02:45.867

If you use DataBinding write a callback in XML:

android:onClick="@{_ -> viewModel.onClickAction()}"

If you use ViewBinding make sure onCreateView and onViewCreated are called. See Android DialogFragment onViewCreated not called.

private lateinit var binding: YourDialogBinding

override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
    binding = YourDialogBinding.inflate(layoutInflater)
    // Create usual or custom dialog
    val builder = AlertDialog.Builder(requireContext()).setView(binding.root)
    return builder.create()
}

// Need to return the view here or onViewCreated won't be called by DialogFragment
override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
    super.onCreateView(inflater, container, savedInstanceState)
    return binding.root
}

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
    super.onViewCreated(view, savedInstanceState)
    with(binding) {
        ...

Custom dialog not working with 'setOnClickListener' Android studio

4 Answers4