Updater Code in C#

Question

Hello I want to create an update mechanic in my program (Windows Form Application). It makes it so when they press login, if there is an update; the program will first update then let them login.

if (!new WebClient().DownloadString(
            "ftp://username:password@wdasd.bplaced.net/test.txt").Contains("1.0.0.0")) {

} 
else 
{
    if (MessageBox.Show("New Update! Would you like to update?", "Yay!",
                            MessageBoxButtons.YesNo, MessageBoxIcon.Information) ==
                            System.Windows.Forms.DialogResult.Yes) 
    {
        Process.Start("ftp://username:password@wdasd.bplaced.net/wdasd.bplaced.net.zip");
    }
}

and the Button code

     private void button2_Click(object sender, EventArgs e)
            {


                //Hash
                var hash = SecurePasswordHasher.Hash("password");

                //Verify
                var result = SecurePasswordHasher.Verify("password", hash);

                if (


                    txtUsername.Text == "" || txt_Password.Text == "")
                {
                    MessageBox.Show("Please provide a Username and Password");
                    return;
                }
                try
                {
                    //Create SqlConnection
                    SqlConnection con = new SqlConnection(cs);
                    SqlCommand cmd = new SqlCommand("Select * from [break].[dbo].[tabl_login] where UserName=@username and Password=@password", con);
                    cmd.Parameters.AddWithValue("@username", txtUsername.Text);
                    cmd.Parameters.AddWithValue("@password", txt_Password.Text);
                    con.Open();
                    SqlDataAdapter adapt = new SqlDataAdapter(cmd);
                    DataSet ds = new DataSet();
                    adapt.Fill(ds);
                    con.Close();
                    int count = ds.Tables[0].Rows.Count;
                    //If count is equal to 1, than show frmMain form
                    if (count == 1)
                    {
                        MessageBox.Show("Login Successful!");

if (!new WebClient().DownloadString(
            "ftp://username:password@wdasd.bplaced.net/test.txt").Contains("1.0.0.0")) {

} 
else 
{
    if (MessageBox.Show("New Update! Would you like to update?", "Yay!",
                            MessageBoxButtons.YesNo, MessageBoxIcon.Information) ==
                            System.Windows.Forms.DialogResult.Yes) 
    {
        Process.Start("ftp://username:password@wdasd.bplaced.net/wdasd.bplaced.net.zip");
    }
}
                    }

                    else
                    {
                        MessageBox.Show("Login Failed!");
                    }
                }
                catch (Exception ex)
                {
                    MessageBox.Show(ex.Message);
                }
            }

I am pretty sure Process.Start is not correct. What would I type into there in order for the program to look into the FTP server for an update?

Please no ClickOnce, I want it to load up update when they click login. Not have the installer.

Answer 1

Perhaps something like the following would do the trick for you :

public async Task CheckForUpdates() {

    using(WebClient wc = new WebClient()) {
        string s = await wc.DownloadStringTaskAsync("ftp://username:password@wdasd.bplaced.net/test.txt");
        if(!s.Contains("1.0.0.0") {
            if (MessageBox.Show("New Update! Would you like to update?", "Yay!",
                MessageBoxButtons.YesNo, MessageBoxIcon.Information) ==
                System.Windows.Forms.DialogResult.Yes)
            {
               await wc.DownloadFileTaskAsync(
                "ftp://username:password@wdasd.bplaced.net/wdasd.bplaced.net.zip",
                @"c:\downloadlocation\tmpupdate.zip"
               );

               // do stuff with file downloaded
            }
        }
    }
    return;

}

You can call this method from inside another function (tagged with async in it's declaration) as follows :

await CheckForUpdates();

For example :

private async void button1_Click( object sender, EventArgs e ) {
    await CheckForUpdates();
}

async / await allow for non-blocking execution of background code while still allowing for UI interaction.

---

Using your revised button code :

private async void button2_Click(object sender, EventArgs e) {
 //Hash
 var hash = SecurePasswordHasher.Hash("password");

 //Verify
 var result = SecurePasswordHasher.Verify("password", hash);

 if (
  txtUsername.Text == "" || txt_Password.Text == "") {
  MessageBox.Show("Please provide a Username and Password");
  return;
 }

 try {
  //Create SqlConnection
  SqlConnection con = new SqlConnection(cs);
  SqlCommand cmd = new SqlCommand("Select * from [break].[dbo].[tabl_login] where UserName=@username and Password=@password", con);
  cmd.Parameters.AddWithValue("@username", txtUsername.Text);
  cmd.Parameters.AddWithValue("@password", txt_Password.Text);
  con.Open();
  SqlDataAdapter adapt = new SqlDataAdapter(cmd);
  DataSet ds = new DataSet();
  adapt.Fill(ds);
  con.Close();
  int count = ds.Tables[0].Rows.Count;
  //If count is equal to 1, than show frmMain form
  if (count == 1) {
   MessageBox.Show("Login Successful!");
   await CheckForUpdates();
  } else {
   MessageBox.Show("Login Failed!");
  }
 } catch (Exception ex) {
  MessageBox.Show(ex.Message);
 }
}

Answer 2

If I understand it correctly. This might be helpful

new WebClient().DownloadFile("ftp://username:password@wdasd.bplaced.net/wdasd.bplaced.net.zip",
                             "C:\\YourDownloadedFile.zip");