Unusual step counter reading

Question

I am trying to build a step counter app for android using the accerlerometer of the mobile. Without restarting the mobile, it gives almost accurate reading. That is for each steps, it increments the value by 1. When the mobile is restarted, the step counter value goes to 0 so i saved the value of the previous reading using the sharedPreferences. But when I start my mobile and start walking, for each steps the step counter increments by 2. How to solve it?

public class Pedometer extends Activity implements SensorEventListener {
    private TextView textView;

    private SensorManager mSensorManager;

    private Sensor mStepCounterSensor;

    private Sensor mStepDetectorSensor;

    SharedPreferences sharedPreferences;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_pedometer);
        textView = (TextView) findViewById(R.id.textview);

        mSensorManager = (SensorManager)
                getSystemService(Context.SENSOR_SERVICE);
        mStepCounterSensor = mSensorManager
                .getDefaultSensor(Sensor.TYPE_STEP_COUNTER);
        mStepDetectorSensor = mSensorManager
                .getDefaultSensor(Sensor.TYPE_STEP_DETECTOR);
    }

    @Override
    public void onSensorChanged(SensorEvent event) {
        sharedPreferences = PreferenceManager.getDefaultSharedPreferences(getApplicationContext());
        SharedPreferences.Editor editor = sharedPreferences.edit();

        Sensor sensor = event.sensor;
        float[] values = event.values;
        int value = -1;
        if (values.length > 0) {
            value = (int) values[0];
        }

        int temp =  sharedPreferences.getInt("steps", 0);

        if (temp > value) {
            temp = temp + 1;
            editor.putInt("steps", temp).commit();
        } else {
            editor.putInt("steps", value).commit();
        }

        int count = sharedPreferences.getInt("steps", 0);

        if (sensor.getType() == Sensor.TYPE_STEP_COUNTER) {
            textView.setText("Step Counter Detected : " + count);
        } else if (sensor.getType() == Sensor.TYPE_STEP_DETECTOR) {
            // For test only. Only allowed value is 1.0 i.e. for step taken
            textView.setText("Step Detector Detected : " + count);
        }
    }

    @Override
    public void onAccuracyChanged(Sensor sensor, int accuracy) {

    }

    @Override
    protected void onResume() {

        super.onResume();

        mSensorManager.registerListener(this, mStepCounterSensor,

                SensorManager.SENSOR_DELAY_FASTEST);
        mSensorManager.registerListener(this, mStepDetectorSensor,

                SensorManager.SENSOR_DELAY_FASTEST);

    }

    @Override
    protected void onStop() {
        super.onStop();
        mSensorManager.unregisterListener(this, mStepCounterSensor);
        mSensorManager.unregisterListener(this, mStepDetectorSensor);
    }
}

I recommend to don´t initialize `SharedPreferences` and `Editor` not on every `onSensorChangedEvent` . That´s a lot of work and you create these Objects Unnecessarily again and again. Just initialize once on onCreate() — Opiatefuchs, Dec 01 '16 at 19:24

score 0 · Answer 1 · edited May 23 '17 at 12:30

0

The problem is that your listener is not unregistered, just as some other people reported. Since you have multiple listeners registered and a shared variable, the steps will be counted twice. To solve this you will need to get a shared state to track if your listener is unregistered.

edited May 23 '17 at 12:30

Community

1
1

answered Dec 01 '16 at 19:25

Nick Vanderhoven

3,018
18
27

I am unregistering the listener on OnStop () method. Please check again – Mehrab Zaman Dec 02 '16 at 05:36
I saw that, but there is a problem with unregistering as is explained in the link I posted in my answer. Sometimes unregistering fails without any warning at all. – Nick Vanderhoven Dec 02 '16 at 05:52

Unusual step counter reading

1 Answers1