0

From a simple Angular 2 + Webpack working project, I'm trying to integrate Apache Thrift by implementing the Thrift's tutorial. I reach a point where everything works except the browser cannot find the Thrift module:

Uncaught ReferenceError: Thrift is not defined

The error is thrown from the thrift generated files, tutorial_types.js, when it tries to access the thrift module:

InvalidOperation = function(args) {
  this.whatOp = null;
  this.why = null;
  if (args) {
    if (args.whatOp !== undefined && args.whatOp !== null) {
      this.whatOp = args.whatOp;
    }
    if (args.why !== undefined && args.why !== null) {
      this.why = args.why;
    }
  }
};
Thrift.inherits(InvalidOperation, Thrift.TException);

Angular loads the application, that loads the generated files that try to load Thrift and fail.

The project is available here: https://github.com/osechet/angular-thrift

To test, run:

git clone https://github.com/osechet/angular-thrift
cd angular-thrift
npm install
npm gen.thrift
npm start

Then open http://localhost:8080/ in a browser.

I checked the files created by Webpack and the thrift module is bundled. What am I missing?

osechet
  • 426
  • 3
  • 11
  • It would be helpful if you could add the part of the code that's throwing the error to your question - it's a lot to ask for people to install your project and run it themselves. – Joe Clay Nov 30 '16 at 12:55
  • 1
    @JoeClay You are right. I added a clarification about it. – osechet Nov 30 '16 at 13:10
  • 1
    Hm, does Thrift actually get imported *in* the generated file? If not, that's probably why things are failing. You'd need to either figure out a way to get Thrift to generate files with `var Thrift = require("thrift");` at the top, or import it from one of your files and attach it to the global environment (`window.Thrift`). – Joe Clay Nov 30 '16 at 13:14
  • @JoeClay Thanks for your comment. It made me find that the js library of Thrift does not export any module. I changed my project to use the browser module of the nodejs library and it works. – osechet Nov 30 '16 at 17:04

1 Answers1

1

Thanks to @JoeClay's remark, I found the problem. The Javascript library provided with Thrift does not export any module and thus isn't properly bundled by Webpack.

I changed my project to use the browser module of the nodejs library provided by Thrift (thrift/lib/nodejs/lib/thrift/browser.js). Doing so, I have been able to make the whole application to work.

osechet
  • 426
  • 3
  • 11