Text based game - std::string some questions from a newbie

Question

I have probably a very simple problem, but as a newbie in programming I just can't find solution even with multiple tries and errors. I'm training what I've learned so far on a simple text based adventure game, which I'm having problems with. For the first I'm using strings and I can't make it to use two strings in if to cout a proper situation.

#include<iostream>
#include <string>
using namespace std;

int main ()
{
    string podpalam = "podpalam";
    string papier = "papier";
    cout << "Stoisz w wielkim ciemny pokoju. W reku trzymasz kawalek PAPIERU, \n a w kieszeni spoczywa pudelko ZAPALEK. Co robisz?" << endl;
    cin >> podpalam >> papier;
    if ( podpalam == "podpalam")
        cout << "Pokoj rozswietla sie od plomieni palacej sie kartki.";
    else
        cout << "Pomysl przez chwile. To niekoniecznie prawidlowe wyjscie." << endl;
    cout << " \nKoniec" << endl;
    return 0;
}

So as you can see I have two strings, both called differently, but only one is added to if, but still you need to cin another string to move forward with the adventure, but the second string can be just a simple letter or symbol. I tried adding two strings to if, but I just can't. Maybe it's impossible and I'm fighting with air, but I've seen games like Zork that used two words and worked perfect.

The other thing is that I don't want my program to end when you make mistake, I want it to restart again. Like you made a mistake, you died and now you can start again. Don't really know the command for it and couldn't find the answer in Google or Youtube.

Answer 1

For starters, especially when you're learning programming, it will be a lot easier to manage your code blocks if you use braces. They make it much easier to see which lines go with which block (you have good indenting though). Ex:

cin >> podpalam >> papier;
if ( podpalam == "podpalam"){
    cout << "Pokoj rozswietla sie od plomieni palacej sie kartki." << endl;
}
else{
    cout << "Pomysl przez chwile. To niekoniecznie prawidlowe wyjscie." << endl;
}

cout << " \nKoniec" << endl;

Secondly, part of your problem could be that you have an endl in the else but not in the if. Adding that to the if should help because end of line characters force the console to flush the output. Without one, it could be that your string was being printed but it was held in a buffer that had not been displayed on the screen yet.

Answer 2

I think you are looking for the boolean and (&&) operator. This checks that both parts of the statement are true and will return false if they are not.

For example:

if(podpalm == "podpalm" && papier== "papier") ... //this code won't run unless both variables 
//are set to what you specify

On the other hand (for future problems) you may need the OR (||) operator. This will return true if either part of the statement is true or if both halfs are true.

There are also other boolean opertors like NOT(!) and XOR(^) but you will be using && and || the most.

EDIT:

If you want the game to restart like you described, put the entire thing in a while loop to check a condition, then set that condition in the code. Here is the example:

#include<iostream>
#include <string>
using namespace std;

int main ()
{
  bool gameOver = false;
  while(gameOver == false) { //condition is met, start loop
    string podpalam = "podpalam";
    string papier = "papier";
    cout << "Stoisz w wielkim ciemny pokoju. W reku trzymasz kawalek PAPIERU, \n a w kieszeni spoczywa pudelko ZAPALEK. Co robisz?" << endl;
    cin >> podpalam >> papier;
    if ( podpalam == "podpalam") {


 cout << "Pokoj rozswietla sie od plomieni palacej sie kartki.";
        gameOver = true; //if it receives this input, end the game
    }
    else {
        cout << "Pomysl przez chwile. To niekoniecznie prawidlowe wyjscie."   << endl;
        gameOver = false; //otherwise, keep the game going.
      }
    cout << " \nKoniec" << endl;
    return 0;
}

Answer 3

Is that I don't want my program to end when you make mistake, I want it to restart again.

Just put the main code of your game into a seperate function and then you call it once the player makes a "bad decision":

#include<iostream>
#include <string>
using namespace std;

void game()
{
    string podpalam = "podpalam";
    string papier = "papier";
    cout << "Stoisz w wielkim ciemny pokoju. W reku trzymasz kawalek PAPIERU, \n a w kieszeni spoczywa pudelko ZAPALEK. Co robisz?" << endl;
    cin >> podpalam >> papier;
    if ( podpalam == "podpalam")
        cout << "Pokoj rozswietla sie od plomieni palacej sie kartki.";
    else
        cout << "Pomysl przez chwile. To niekoniecznie prawidlowe wyjscie." << endl;
    cout << " \nKoniec" << endl;

    //somewhere where the player made a bad decision:
    game(); //restart the game.
    return; // return from the function.
}

int main ()
{
  game();
  return 0;
}

Don't try to call main() inside main() because that's undefined behaviour.