Flask passing another url through url variable

Question

I'm trying to build a cors proxy through flask from scratch. Here's my code

@app.route('/api/v1/cors/url=<name>&method=<method>', methods=['GET'])
def api_cors(name, method):
    if method == 'http' or method == 'https':
        r = request.urlopen(method+"://"+name)
        return r.read()
    else:
        return "method not set!"

It is working good so far but I have one problem, when I pass "url=google.com&method=https" it is working fine but when I pass something like "url=google.com/images/image.jpg&method=https" the "/" will considered as a new directory

Is there anyway to evade this in flask?

can you try with keeping it between inverted commas like "url='google.com/images/image.jpg'&method=https" — SunilThorat, Nov 19 '16 at 15:21
@SunilT how would i go about doing that, wouldnt it be bypassed anyway — Val G., Nov 19 '16 at 15:25
Please refer http://stackoverflow.com/questions/2992231/slashes-in-url-variables.. seems there are multiple solutions to solve this. — SunilThorat, Nov 19 '16 at 15:39

score 4 · Answer 1 · answered Nov 19 '16 at 15:41

4

Don't try and pass the value as part of the route itself. Pass it as a query parameter.

@app.route('/api/v1/cors/')
def api_cors():
    url = request.args.get('url')

and call it as "/api/v1/cors/?url=https://google.com/images/image.jpg".

answered Nov 19 '16 at 15:41

Daniel Roseman

588,541
66
880
895

hey i get attribute error when doing the same as you did – Val G. Nov 19 '16 at 17:27
AttributeError: 'module' object has no attribute 'args' – Val G. Nov 19 '16 at 17:28
i did import request btw,: from flask import request – Val G. Nov 19 '16 at 17:32
Do you have a `request.py` that you import somewhere? – dirn Nov 19 '16 at 18:30
have it where? isnt it supposed to come as a package, plus i dont get any import errors – Val G. Nov 19 '16 at 18:45
I want to get the url without using `?url=` any possibility? – Pyd Jun 18 '18 at 16:39
For people having issues with `request`, try `from flask import request`. – Rishik Mani Apr 26 '21 at 07:30

score 2 · Accepted Answer · answered Nov 19 '16 at 16:49

2

If you want use the same URL scheme that you're using now, change your routing decorator to this and it will work.

@app.route('/api/v1/cors/url=<path:name>&method=<method>', methods=['GET'])

answered Nov 19 '16 at 16:49

Jake Conway

901
16
25

Flask passing another url through url variable

2 Answers2