Silencing clang-tidy

Question

I have a build which uses clang-tidy through cmake:

set_target_properties(project
    PROPERTIES
    ...
    CXX_CLANG_TIDY
        "/usr/bin/clang-tidy"
        "-checks=modernize-*,readability-*,performance-*"
        "-fix"
)

While building it I am getting a possible memory leak inside the Qt libraries:

/opt/Qt5.7.0/5.7/gcc_64/include/QtCore/qobject.h:242:16: warning: Potential memory leak [clang-analyzer-cplusplus.NewDeleteLeaks]
        return connectImpl(sender, reinterpret_cast<void **>(&signal),
               ^
.../a.cpp:27:5: note: Taking false branch
    if (not inputQFile.makeAbsolute()) {
    ^
.../a.cpp:33:5: note: Calling 'QObject::connect'
    connect(this, static_cast<void (QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished),
    ^
/opt/Qt5.7.0/5.7/gcc_64/include/QtCore/qobject.h:238:13: note: Left side of '||' is false
        if (type == Qt::QueuedConnection || type == Qt::BlockingQueuedConnection)
            ^
/opt/Qt5.7.0/5.7/gcc_64/include/QtCore/qobject.h:238:9: note: Taking false branch
        if (type == Qt::QueuedConnection || type == Qt::BlockingQueuedConnection)
        ^
/opt/Qt5.7.0/5.7/gcc_64/include/QtCore/qobject.h:242:16: note: Potential memory leak
        return connectImpl(sender, reinterpret_cast<void **>(&signal),
               ^

How can I silence this?

What I already tried:

Add a // NOLINT to the end of a.cpp:33 -> no effect
Add a // NOLINT to the end of qobject.h:242 -> no effect
Wrap qobject.h:242 in a #ifndef __clang_analyzer__ -> no effect
Wrap all of qobject.h in a #ifndef __clang_analyzer__ -> no effect
Add // NOLINT to all lines of connectImpl -> clang-tidy crashes

@Tarod: Here is what I currently have:

#ifndef __clang_analyzer__
        return connectImpl(sender, reinterpret_cast<void **>(&signal),
                           receiver, reinterpret_cast<void **>(&slot),
                           new QtPrivate::QSlotObject<Func2, typename QtPrivate::List_Left<typename SignalType::Arguments, SlotType::ArgumentCount>::Value, // NOLINT
                                           typename SignalType::ReturnType>(slot),
                            type, types, &SignalType::Object::staticMetaObject); // NOLINT
#endif //__clang_analyzer__

`#ifndef __clang_analyzer__` should work. Are you putting `#endif` at the end of `qobject.h` file? — Tarod, Nov 20 '16 at 14:21
Same issue if you put `#ifndef __clang_analyzer__` at the beginning of the `qobject.h` file? — Tarod, Nov 23 '16 at 06:29
@Tarod added the whole file in the #ifndef and still prints the error... — Mac, Nov 23 '16 at 19:53
Mmm... Could you try with `ifdef` instead of `ifndef`? Just to see the difference in the analysis. — Tarod, Nov 23 '16 at 21:05
I assume this question is unrelated to both [qt] and [cmake]. It is a pure clang-tidy question, right? — usr1234567, Nov 26 '16 at 11:32

score 3 · Answer 1 · answered Nov 23 '16 at 09:05

3

I think you must comment all of your 5 lines of connectImpl() or similar since // NOLINT affects a single code line, only.⁽¹⁾

answered Nov 23 '16 at 09:05

falkb

1,294
11
35

If I do that clang-tidy crashes... Error running '/usr/bin/clang-tidy' – Mac Nov 23 '16 at 19:55
3

muahaha, this looks like a well-tested tool... ;) Do you use their latest version? – falkb Nov 24 '16 at 07:43
Yup I did use the latest version. 3.9.1 – Mac Nov 28 '16 at 18:22

score 1 · Answer 2 · answered Apr 10 '19 at 16:38

1

If you used clang-tidy in the QtCreator see

https://bugreports.qt.io/browse/QTCREATORBUG-20744

QtCreator uses the extra-tools and that lib doesnt support //NOLINT etc yet.

answered Apr 10 '19 at 16:38

roy

11
2

Silencing clang-tidy

2 Answers2