Weird if-else behaviour Javascript

Question

The else-statement below never executes even if the if-statement is false. I think I've made some very basic mistake but can't figure out what.

var a = ["king","queen","100"];
    for (var i=0; i<a.length; i++) {
        if (a[i] === "king" || "queen"){
            console.log("monarch");
        }
        else {
            console.log("The number is: "+ parseInt(a[i]));
        }
    }
// This prints out "monarch" 3 times

"queen" is a truthy value. Do this `a[i] === "king" || a[i] === "queen"` — Ori Drori, Nov 13 '16 at 14:15
thanks it worked but shouldn't both king and queen be false for a[2] — Bijay Timilsina, Nov 13 '16 at 14:17
you do not need `parseInt(a[i])`, because you add a string to the string. — Nina Scholz, Nov 13 '16 at 14:19
Take note, when you say `a[i] === "king" || "queen"` you are asking if a[i] equals to "king", and after you ask another question, literaly `"queen"`, but you want to ask `a[i]==="queen"`. so your conditional should be like @OriDrori says — Hugo David Farji, Nov 13 '16 at 14:20

Joe · Accepted Answer · 2018-02-20T17:40:49.247

1

Should be:

var a = ["king","queen","100"];
for (var i=0; i<a.length; i++) {
    if (a[i] === "king" || a[i] ===  "queen"){
        console.log("monarch");
    }
    else {
        console.log("The number is: "+ parseInt(a[i]));
    }
}

You wrote your boolean expression the way we would speak a spoken language, "A is either 1 or 2". That's not the way the OR is interpreted.

Either the left side of the OR is true: a[i] === "king" is true; or the right side of the OR is true: "queen". It's evaluating the string by itself, and the string "queen" is not null, so it evaluates to true.

edited Feb 20 '18 at 17:40

answered Nov 13 '16 at 14:15

Joe

1,091
1
11
23

1

so you mean the way javascript checks the condition is : either a[i]="king" or "queen" in which case for a[2] the if a[2]="king" is false but if the lone ("queen") is still correct right? – Bijay Timilsina Nov 13 '16 at 14:25
1

@BijayTimilsina exactly! – Tiago Marinho Nov 13 '16 at 14:26
1

@TiagoMarinho - nice edits, thanks for the additional clarification. – Joe Nov 14 '16 at 20:48

score 0 · Answer 2 · answered Nov 13 '16 at 14:16

0

You gotta make your two conditions separately with || as follow: a[i] === "king" || a[i] === "queen"

answered Nov 13 '16 at 14:16

Basim Hennawi

2,651
3
19
31

Weird if-else behaviour Javascript

2 Answers2