Syncing but not closing a dbm

Question

Is it a problem to do :

import time
import dumbdbm

db = dumbdbm.open('db.db', 'c')

# modify the persistent dict / "DB" here
db['foo'] = 'bar'
db.sync()        

while True:
    # doing other things, sometimes modifying the db + syncing with .sync()
    time.sleep(1)

and to break the program with CTRL + C during the sleeping time, i.e. the dumbdbm will not be properly closed ?

Is dumbdbm.sync() enough to guarantee safety of the datas, or is .close() absolutely mandatory?

@ScottHunter, it was a simplified code of my whole thing. I modified. — Basj, Oct 25 '16 at 00:34

gbe · Accepted Answer · 2016-10-25T03:15:31.977

1

The documentation implies syncing is enough when it says that calling that method synchronized the on-disk directory and data files.

However, I think the better approach here is to close the file before exiting. If you're always exiting with Ctrl-C, you can make this happen by registering a signal handler for SIGINT (which is the signal sent by Ctrl-C.) This signal handler should sync, close the DB, then call exit().

edited Oct 25 '16 at 03:15

answered Oct 25 '16 at 00:57

gbe

671
3
11

Thanks @gbe. Can you cite which part of the doc says it's enough? – Basj Oct 25 '16 at 01:05
I've edited my answer to include a reference to that part of the documentation. – gbe Oct 25 '16 at 03:16

Syncing but not closing a dbm

1 Answers1