reached while popover is still visible

Question

-(void)showsearch:(id)sender
{
    SearchViewController *searchview =[[SearchViewController alloc] initWithNibName:@"SearchViewController" bundle:nil];

    settingpopoverController = [[[UIPopoverController alloc] 
                                    initWithContentViewController:searchview] autorelease];               
    [searchview release];
    [settingpopoverController presentPopoverFromBarButtonItem:sender 
                                    permittedArrowDirections:UIPopoverArrowDirectionAny animated:YES];


}

When I click on button, the app is crash and I got [UIPopoverController dealloc] reached while popover is still visible. message.

you seem to be mixing up *view* and *controller*. is SearchViewController a controller, but you call it a view. — Ross, Oct 24 '10 at 16:13

score 6 · Answer 1 · edited May 23 '17 at 10:34

There are some good discussions on this topic here:

Retain/release pattern for UIPopoverController, UIActionSheet, and modal view controllers?

UIPopoverController and memory management

The gist of it is you need to:

assign your autoreleased popover to a retain property
set the property to nil in your view's dealloc
as well as setting it to nil in the popoverControllerDidDismissPopover.

score 3 · Accepted Answer · answered Oct 24 '10 at 16:12

3

think autorelease is incorrect, here is a tutorial

http://www.jannisnikoy.nl/index.php/2010/04/ipad-tutorial-creating-a-popoverviewcontroller

answered Oct 24 '10 at 16:12

Aaron Saunders

33,180
5
60
80

@saturngod glad to be of help – Aaron Saunders Oct 24 '10 at 16:17
-1 Blog post does not explain why the poster's code crashed. It only is a tutorial for popovers – Sonny Saluja Apr 30 '11 at 00:22
1

@Sanjit Sauja, essentially the addition of `autorelease` in the code IS what makes the code crash. Either you `retain` your `UIPopoverController` or experience the crash that the OP asks about. – Dan Rosenstark May 01 '11 at 12:40

score 3 · Answer 3 · answered Nov 30 '10 at 20:28

3

Problem is you're setting

settingpopoverController =

when you mean to do

self.settingpopoverController =

for which the autorelease would be correct. The second one uses the property accessors, the first just uses the iVar.

answered Nov 30 '10 at 20:28

Dan Rosenstark

68,471
58
283
421

@Sanjit Saluja, in Obj-c 2.0 and beyond, the second syntax -- assuming it's a "retain" property -- would call "retain" on the `UIPopoverController` that the OP calls autorelease on. Otherwise when the current method ends, the `UIPopoverController` is autoreleased, reaches a retain count of 0, and is dealloc'ed. Let me know if you think I'm missing something. – Dan Rosenstark Apr 30 '11 at 06:41

reached while popover is still visible

3 Answers3