Reader doesn't return all rows from database

Question

So i have a web api that presents values from my database. However i have 6 rows in my database, but it doesn't return the first row.

How do i get it to read and return all rows in my database?

        cmd.CommandText = "SELECT * FROM `CustomerDb`";
        cmd.CommandType = CommandType.Text;
        cmd.Connection = mySqlConnection;

        mySqlConnection.Open();
        MySqlDataReader reader = cmd.ExecuteReader();

        var listOfPlace = new List<Place>();

        if (reader.Read())
        {
            while (reader.Read())
            {
                var Place = new Place();
                Place.ID = Convert.ToInt32(reader["id"]);
                Place.Name = reader["name"].ToString();
                Place.Address = reader["address"].ToString();
                Place.City = reader["city"].ToString();
                Place.Category = reader["category"].ToString();

                listOfPlace.Add(Place);
            }
        };
        return listOfPlace;

Vivek Nuna · Accepted Answer · 2023-01-13T07:11:31.260

1

Remove if block.

if (reader.Read())
{

edited Jan 13 '23 at 07:11

answered Oct 16 '16 at 17:02

Vivek Nuna

25,472
25
109
197

Thank you. But dont i need try catch exceptions then ? – Jeppe Christensen Oct 16 '16 at 17:05
why do you think so? but If you want to handle it for other purpose then you can use – Vivek Nuna Oct 16 '16 at 17:06
Great! Thank you. Right now it returns on the in ascending order. How can i make it return in the order that i have made inside the loop (ID, Name, address, city,category)? – Jeppe Christensen Oct 16 '16 at 17:07
I didn't get your point. order does not matter here, by the way you can modify your query also to to define the order of columns – Vivek Nuna Oct 16 '16 at 17:09
Oh yea! the query. I forgot. Thank you again sir :) – Jeppe Christensen Oct 16 '16 at 17:13

score 0 · Answer 2 · answered Oct 16 '16 at 17:02

The first reader.Read() inside if statement read the first row then while loop start from the second row so you need to remove the if(reader.Read()) portion to read all data from the beginning

while (reader.Read())
  {
      var Place = new Place();
      Place.ID = Convert.ToInt32(reader["id"]);
      Place.Name = reader["name"].ToString();
      Place.Address = reader["address"].ToString();
      Place.City = reader["city"].ToString();
      Place.Category = reader["category"].ToString();

      listOfPlace.Add(Place);
  }

Reader doesn't return all rows from database

2 Answers2