git-gui command crashes on macOS Sierra

Question

After update to macOS Sierra, git-gui command crashes with an error:

Wish[23862:202062] *** Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [0 nan]'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff8cd9252b __exceptionPreprocess + 171
    1   libobjc.A.dylib                     0x00007fffa146acad objc_exception_throw + 48
    2   CoreFoundation                      0x00007fff8ce10a0d +[NSException raise:format:] + 205
    3   QuartzCore                          0x00007fff92938980 _ZN2CA5Layer12set_positionERKNS_4Vec2IdEEb + 152
    4   QuartzCore                          0x00007fff92938af5 -[CALayer setPosition:] + 44
    5   QuartzCore                          0x00007fff9293914b -[CALayer setFrame:] + 644
    6   CoreUI                              0x00007fff986e2112 _ZN20CUICoreThemeRenderer26MakeOrUpdateScrollBarLayerEPK13CUIDescriptoraPP7CALayer + 1284
    7   CoreUI                              0x00007fff986de317 _ZN20CUICoreThemeRenderer19CreateOrUpdateLayerEPK13CUIDescriptorPP7CALayer + 1755
    8   CoreUI                              0x00007fff986604d1 _ZN11CUIRenderer19CreateOrUpdateLayerEPK14__CFDictionaryPP7CALayer + 175
    9   CoreUI                              0x00007fff98663185 CUICreateOrUpdateLayer + 221
    10  AppKit                              0x00007fff8b3c7623 -[NSCompositeAppearance _callCoreUIWithBlock:options:] + 226
    11  AppKit                              0x00007fff8aa74a9d -[NSAppearance _createOrUpdateLayer:options:] + 76
    12  AppKit                              0x00007fff8aced143 -[NSScrollerImp _animateToRolloverState] + 274
    13  AppKit                              0x00007fff8acacb79 __49-[NSScrollerImp _installDelayedRolloverAnimation]_block_invoke + 673
    14  AppKit                              0x00007fff8ab73331 -[NSScrollerImp _doWork:] + 15
    15  Foundation                          0x00007fff8e770c88 __NSFireDelayedPerform + 417
    16  CoreFoundation                      0x00007fff8cd11e14 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
    17  CoreFoundation                      0x00007fff8cd11a9f __CFRunLoopDoTimer + 1071
    18  CoreFoundation                      0x00007fff8cd115fa __CFRunLoopDoTimers + 298
    19  CoreFoundation                      0x00007fff8cd09021 __CFRunLoopRun + 2065
    20  CoreFoundation                      0x00007fff8cd085b4 CFRunLoopRunSpecific + 420
    21  Tcl                                 0x0000000101834b43 Tcl_WaitForEvent + 314
    22  Tcl                                 0x00000001018045cd Tcl_DoOneEvent + 274
    23  Tk                                  0x0000000101672f4f Tk_MainLoop + 33
    24  Tk                                  0x000000010167ea5b Tk_MainEx + 1566
    25  Wish                                0x0000000101658542 Wish + 9538
    26  libdyld.dylib                       0x00007fffa1d48255 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
error: git-gui died of signal 6

Does anybody have the same problem and a solution for this?

Related: [CALayerInvalidGeometry', reason: 'CALayer bounds contains NaN: crash in view](https://stackoverflow.com/q/4867968/55075) — kenorb, Sep 21 '17 at 10:35
Related: [What causes this error? “CALayer position contains NaN: 240 nan”](https://stackoverflow.com/q/3025176/55075) — kenorb, Sep 21 '17 at 10:42

Nainy Agrawal · Answer 1 · 2016-10-12T06:46:09.533

24

Try: git config --local --unset gui.geometry
This error occurs due to Tk Geometry manager does not work, due to older version or if it is corrupt.

If the above command didn't work try updating your xcode: xcode-select --install

edited Oct 12 '16 at 06:46

answered Oct 03 '16 at 19:02

Nainy Agrawal

341
1
6

3

I've tried this solution it does not work for me https://github.com/git/git-scm.com/issues/853 – sbondaryev Oct 03 '16 at 19:53
1

doesn't seem to work, even with the `xcode-select --install` edit – paulski Oct 12 '16 at 18:56
1

this worked for me and it makes sense too ! Thank you – Mathieu J. May 30 '19 at 01:58

score 23 · Accepted Answer · edited Aug 17 '17 at 21:14

23

Instead of using the default MacOS tcl-tk, use the latest tcl-tk(8.6.6) from Homebrew and then link it by force, for example:

brew install tcl-tk
brew link tcl-tk --force

edited Aug 17 '17 at 21:14

kenorb

155,785
88
678
743

answered Oct 18 '16 at 22:20

ssahu

878
3
10
22

Thank you, the accepted answer didn't work for me, but this does. – yxhuvud Dec 01 '16 at 14:28
This answer worked for me, but only after I fixed the issue I had with my PATH variable, which had `/usr/bin/` before `/usr/local/bin`. This had the effect that I couldn't change the version of `Wish` used by `gitk`. – JBL Dec 12 '16 at 11:49
4

I had to do `brew install homebrew/dupes/tcl-tk` – pius Dec 22 '16 at 22:37
did this… it's still crashing for me – Clintm Mar 13 '17 at 04:28
1

`brew install homebrew/dupes/tcl-tk` no longer works. homebrew/dupes was deprecated. – ebelisle Feb 26 '19 at 18:39

sbondaryev · Answer 3 · 2016-12-01T15:42:15.980

19

There is a problem with Tk 8.5 on MacOS Sierra. You could replace Tk Wish 8.5 with Tk Wish 8.4

cp /System/Library/Frameworks/Tk.framework/Versions/8.4/Resources/Wish.app/Contents/MacOS/Wish /usr/local/Cellar/git/2.10.1/share/git-gui/lib/Git\ Gui.app/Contents/MacOS/

source: https://github.com/git/git-scm.com/issues/853

UPD: Pay attention to replace the git version in the cp path with your current version

edited Dec 01 '16 at 15:42

answered Oct 10 '16 at 21:02

sbondaryev

839
6
10

This did not work for me. The answer by ssahu did work, however. – yxhuvud Dec 01 '16 at 14:27
Yes. the ssahu's solution should also work, anyway the idea is to replace the Tcl/tk 8.5 version with another one. You should also use your current git version in the target path of `cp` command. – sbondaryev Dec 01 '16 at 15:39
I would recommend upgrading Tk to 8.6 rather than downgrading to 8.4, since 8.4 has its own set of disadvantages. For me, it was annoying that it did not support my macbook's retina display. See answers by ssahu and Bruce for how to do that. – pius Dec 22 '16 at 22:43
I tried many solutions and this is the only one that worked for me! Thank you!!! By the way, also pay attention to use your current Tk version. – Dmitry Kamenetsky Apr 15 '20 at 12:57

score 7 · Answer 4 · answered Nov 02 '16 at 07:49

My solution, should work for the git download from https://git-scm.com/

brew install homebrew/dupes/tcl-tk

cd to /usr/local/git/share/git-gui/lib/Git Gui.app/Contents/MacOS and backup the original Wish

cp /usr/local/Cellar/tcl-tk/8.6.6/bin/wish8.6 /usr/local/git/share/git-gui/lib/Git Gui.app/Contents/MacOS/Wish

score 5 · Answer 5 · edited Aug 17 '17 at 21:16

5

I conglomerated a bunch of answers from here together, since I am using GIT and TCL via brew:

cd "/usr/local/Cellar/git/2.10.2/share/git-gui/lib/Git Gui.app/Contents/MacOS"
mv Wish Wish.bkp
ln -vs /usr/local/Cellar/tcl-tk/8.6.6/bin/wish8.6 Wish

Over time obviously the version numbers may vary

edited Aug 17 '17 at 21:16

kenorb

155,785
88
678
743

answered Nov 27 '16 at 01:06

Malachi

2,260
3
27
40

score 5 · Answer 6 · edited Sep 21 '17 at 11:15

I consider the following goals to constitute the full solution to the problem:

"Nuke from orbit" certainty in solving this in a neat and linear fashion
Do not end up with ugly fonts from a legacy Apple Tcl/Tk
Decouple your git gui from the Apple shipped Tcl/Tk
- Rely on Homebrew for your Tcl/Tk installation

Below you will find a step-by-step to achieve this:

Get the duplicated Tcl/Tk from Homebrew
```
brew install tcl-tk
```
Add the non-broken Tcl/Tk installation to the path(s) before the broken Apple implementation
- This assumes your Homebrew paths take precedence over your system paths
- This should be the case in a normal Homebrew installation
- This will fail if you have conflicting files from your other installed homebrew recipes
- For example the_platinum_searcher provides pt, which conflicts
- I recommend ripgrep for getting around this case
```
brew link --force tcl-tk
```
Fix your gitk installation by reinstalling against the nonbroken Homebrew version
- This might not be necessary, but ref. the first stated goal above
```
brew reinstall git
```
Copy the new wish binary from your Homebrew Tcl/Tk installation over the broken bundled one from Apple in the Git Gui.app bundle
- This blindly relies on the ouput of homebrew info <package> to not change
```
cp "$(which wish)" "$(brew info git | grep Cellar | cut -d' ' -f1)/share/git-gui/lib/Git Gui.app/Contents/MacOS/Wish"
```

The last bit might be wise to slap into an alias into your ~/.bashrc and/or equivalent as it'll have to be repeated every time you get a new git version from Homebrew.

alias fix-gitgui='cp "$(which wish)" "$(brew info git | grep Cellar | cut -d" " -f1)/share/git-gui/lib/Git Gui.app/Contents/MacOS/Wish"'

I am not fully certain why the quoting for the field delimiter character for cut used above works so use this alias with caution as this might very well depend on an exact bash version.

Thanks. The alias worked for me on Mojave (10.14.3), and I'm happy to have it for future use. err: Wish[98243:1226829] *** Assertion failure in -[_NSCGSWindow setFrame:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1671.20.108/CGS.subproj/NSCGSWindow.m:1015 2019-03-21 11:55:18.876 Wish[98243:1226829] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: CGRectContainsRect(CGRectMake((CGFloat)INT_MIN, (CGFloat)INT_MIN, (CGFloat)INT_MAX - (CGFloat)INT_MIN, (CGFloat)INT_MAX - (CGFloat)INT_MIN), frame)' — Jason, Mar 21 '19 at 17:29

score 2 · Answer 7 · answered Dec 24 '16 at 14:13

2

Upgrading to macOS 10.12.2 fixes the problem.

References:

https://github.com/git/git-scm.com/issues/853#issuecomment-268266122
Personal experience

No insight into why from Apple change log: https://support.apple.com/en-us/HT207307.

answered Dec 24 '16 at 14:13

Kenn Sebesta

7,485
1
19
21

score 0 · Answer 8 · answered Oct 15 '16 at 02:41

It works for me: download and install the latest version of TCL (I used 8.6.4) http://www.activestate.com/activetcl/downloads

I also downloaded and installed the latest version (2.10.1) of git https://git-scm.com/

Check that gitk window does not crash after the resizing.

score 0 · Answer 9 · answered Oct 28 '16 at 03:39

@sbondaryev's answer (39966704) didn't work for me and I've yet to try @ssahu's (40119030). However the trick I describe here crashed far less often (10% of time or so) for me. And it keeps me from messing around too much with things - hopefully the problem will be fixed properly soon.

Crashing seemed to happen when resizing the window (90% of time). But I found it too small to work with and wanted to resize it.
vi .git/config
edit the GUI geography to create a window size that works. I still kept it small though i suspect there will be a size over which crashing will always happen

jalairo · Answer 10 · 2016-12-19T14:33:54.853

My Sierra (upgraded from 10.11.6) has Tcl/Tk Current pointing to 8.5 and I observed the same error after the upgrade, with our Python program using Tkinter. I'm not using Wish. I had no help from Python 2.7 32bit installation linked to Tcl/Tk 8.4 as that one did not have "tile". So I brewed my Python, linking it with Tcl/Tk 8.6:

This is for brew to use precompiled bottles instead of building from sources, unless specifically instructed otherwise, so not really causing the issue:

xcode-select --install

Then install Tcl/Tk:

brew install homebrew/dupes/tcl-tk

If you did not install Python originally with --with-tcl-tk, then:

brew uninstall python

Finally:

brew install python --with-tcl-tk

After this I have Python that is linked to Tcl/Tk 8.6 and looks like I got rid of the error.

score 0 · Answer 11 · edited Aug 17 '17 at 21:27

0

This has been resolved on the most recent patches to macOS Sierra (10.12.2 and above) and no further action is necessary.

edited Aug 17 '17 at 21:27

kenorb

155,785
88
678
743

answered Feb 12 '17 at 01:17

James Fry

1,133
1
11
28

I'm using macOS Sierra 10.12.5 (August 2017) and the crash was still there. – kenorb Aug 17 '17 at 21:19
How did you install git? I'm using the homebrew installation and it's now fine (it appeared to be the Sierra update that fixed it as I didn't update git). I've since reinstalled OSX and reinstalled git using brew and it's working fine (as it does for 2-3 other Mac's I have regular visibility of). I cannot speak for the stability of the git installer from the git website. I'm using a 2015 15" rMBP and 2013 13" rMBP, other Mac is a c. 2013 Air. – James Fry Aug 17 '17 at 21:24
I'm using git 2.14.1 installed by brew, I've tried installing `tcl-tk` via `brew` and it helped. – kenorb Aug 17 '17 at 21:26
I have the following brew packages only installed - freetds freetype git graphicsmagick imagemagick jpeg libpng libtiff libtool openssl pgloader postgresql readline sbcl xz. I am running 10.12.6 and brew 1.3.0. git --version reports "git version 2.14.0" and `which git` is "/usr/local/bin/git". – James Fry Aug 17 '17 at 21:29

score 0 · Answer 12 · answered Jun 15 '17 at 11:26

After a lot of struggles this solution solves my problem:

$ brew upgrade tcl-tk

If it's up-to-date and this does not work, try:

$ brew uninstall tcl-tk
$ brew install tcl-tk

I have tried every solution in the web but only this solves the problem. Cheers!

score 0 · Answer 13 · answered Oct 18 '17 at 13:04

0

On High Sierra (10.13) I had the same issue with git gui.

I have solved the issue by updating git from 2.7.0 to 2.14.2

brew upgrade git

answered Oct 18 '17 at 13:04

Rammgarot

1,467
14
9

This worked for me after upgrading to High Sierra. I got git 2.17.1 – John Lindal Jun 20 '18 at 22:12

score 0 · Answer 14 · answered May 14 '18 at 08:27

0

A fix that worked for me: disconnect second monitor, open git gui -> works, close it, reconnect the second monitor and run git gui -> works again :)

answered May 14 '18 at 08:27

Yo Ludke

2,149
2
23
38

git-gui command crashes on macOS Sierra

14 Answers14