Python alphabet shifting string

Question

i have tried but can't seem to find my mistake in my code. My code is suppose to switch all the alphabetic characters (like a/aa/A/AA) and do nothing with the rest but when i run the code it doesn't give an error yet do what i want.

Could anyone tell me what i have done wrong or have forgotten?

letter = input("type something")
shift = int(input("type how many shifts"))
if letter in ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z']:
    a = ord(letter) + shift
    b = chr(a)
    print(b)
else: 
    print(letter)

EDIT: thanks for the == replacement for in! Does someone know why using more than one character in letter gives the same print?(Desired output: when i put in abc and 1 i want it to print bcd)

If you want it to make you a margarita you're going to need to try a different approach. If you're not trying to make margaritas it would help if you explained your *desired output*. — Wayne Werner, Oct 01 '16 at 20:51
Use `isalpha()` to check for letters, Check this: http://stackoverflow.com/questions/15558392/how-to-check-if-character-in-string-is-a-letter-python — Saeid, Oct 01 '16 at 20:54
Give an simple input/output example will be the best way to give a vision of your problem — RandomEli, Oct 01 '16 at 20:54
`if letter in ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z']:` — George Bou, Oct 01 '16 at 20:55
Desired output means you should put something like "*When I put in 'frobnosticate' and 2, I expect that it will output `fizz buzz`, but it prints `crazy time` instead*." — Wayne Werner, Oct 01 '16 at 21:01

score 1 · Answer 1 · answered May 06 '23 at 20:51

#a is the string you want to encrypt, b is the number you shift by
a,b = input().split()
x = int(b)
#code to make sure that the shift is less than 26
for i in range(x):
  if x > 26:
    x = x - 26
  else:
    break
#driver code
print(''.join(map(chr,([ord(c)+x for c in a]))))

shubham003 · Accepted Answer · 2016-10-01T21:07:24.137

0

I suppose you want to shift the letters so if the input letter is 'a' and shift is 3, then the output should be 'd'.

In that case replace

if letter == ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z']:

with

if letter in ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z']:

Or better yet as Tempux suggested you can use

if letter.isalpha()

If you want to shift multple letters you need to loop across each character. Try the following code for multiple letters

letter = input("type something")
shift = int(input("type how many shifts"))
s = ""
for l in letter:
    if l.isalpha():
        a = ord(l) + shift
        s += chr(a)
    else: 
        s += l

print(s)

edited Oct 01 '16 at 21:07

answered Oct 01 '16 at 20:54

shubham003

703
2
9
20

He mentioned that he want "the amount of shifts" – RandomEli Oct 01 '16 at 20:55
i'm pretty sure he meant the letter after the amount of shifts, because the amount is something the user enters in the first place – George Bou Oct 01 '16 at 20:56
Omg thanks such an easy fix, i do have another problem now, when i try multiple letters nothing happens... – Omar Oct 01 '16 at 21:00
@Omar I edited the answer with code when multiple letters are entered. If it works please accept the answer. – shubham003 Oct 01 '16 at 21:08
@shubham003 it indeed works but i haven't had isalpha in class yet so i may not use it. Is there no other way than using this? – Omar Oct 01 '16 at 21:13
Instead of if l.isalpha() you can use if l in ['a','b','c',...]. – shubham003 Oct 01 '16 at 21:17

score 0 · Answer 3 · answered Oct 01 '16 at 20:55

0

You compare letter with list, but i think you want to check for contain letter in list, so you should just replace == to in

answered Oct 01 '16 at 20:55

AyumuKasuga

189
1
8

thanks a lot! like i mentioned on shubbam103 i do have another problem still where multiple letters don't work.... – Omar Oct 01 '16 at 21:01

score 0 · Answer 4 · answered Oct 01 '16 at 21:06

From the looks of it, I'd say you're more after something like this:

import string
text = input("type something> ")
shift = int(input("enter number of shifts> "))
for letter in text:
    index = ord(letter) - ord('a') + shift
    print(string.ascii_letters[index % len(string.ascii_letters)])

Python alphabet shifting string

4 Answers4