Java- How can you close `FileInputStream` in finally block if the same method returns that `FileInputStream`

Question

Sonar is showing a bug for the below code which is of blocker type. It's complaining that I have not closed FileInputStream but how can I do that? FileInputStream is the return type of method and if I close here then it will be of no use from where it's calling. Please let me know- how can I close FileInputStream in finally block if the same method returns that FileInputStream?

Here is the code:

@Override
public InputStream getInputStream() throws MissingObjectException {

    try {
        InputStream is;
        if (smbFile != null) {
            is = new BufferedInputStream(new SmbFileInputStream(smbFile), 60000);
        } 
        else {
            is = new BufferedInputStream(new FileInputStream(getFilePath()));
        }
        return is;
    }
    catch (Exception e) {
            throw new MissingObjectException();
    }
}

Paste your code in the question in text form with proper formatting. — progyammer, Sep 28 '16 at 10:16
@Antoniossss and he said that. He does not want to close it, he express wondering why IDE is complaining. — Wojtek, Sep 28 '16 at 10:25

Wojtek · Accepted Answer · 2016-09-28T10:26:58.077

2

It is not necessary to close the input in the same function. The problem may be that you should not declare InputStream is in try{} block as well as putting the return statement.

edited Sep 28 '16 at 10:26

answered Sep 28 '16 at 10:19

Wojtek

1,288
11
16

score 0 · Answer 2 · answered Sep 28 '16 at 10:21

Put is declaration before try block

 InputStream is= null;
try {
    if (smbFile != null) {
        is = new BufferedInputStream(new SmbFileInputStream(smbFile), 60000);             } else {
        is = new BufferedInputStream(new FileInputStream(getFilePath()));
    }
    return is;
}
catch (Exception e) {
        throw new MissingObjectException();
}finally{
  if(is !=null){
  is.close();
 }
}

Java- How can you close `FileInputStream` in finally block if the same method returns that `FileInputStream`

2 Answers2