Converting into Generic class

Question

I have trouble understanding generics concept. I need to convert class DataSet into its generic form. I especially don't get what to do with the fields of DataSet. I do understand that we have to substitute all the signatures with T.

/**
   Computes the average of a set of data values.
*/
public class DataSet
{
   private double sum;
   private Measurable maximum;
   private int count;

   /**
  Constructs an empty data set.
  */
   public DataSet()
   {
      sum = 0;
      count = 0;
      maximum = null;
   }

   /**
      Adds a data value to the data set.
      @param x a data value
   */
   public void add(Measurable x)
   {
      sum = sum + x.getMeasure();
      if (count == 0 || maximum.getMeasure() <       x.getMeasure())
          maximum = x;
         count++;
        }

   /**
      Gets the average of the added data.
      @return the average or 0 if no data has been added
   */
   public double getAverage()
   {
      if (count == 0) return 0;
      else return sum / count;
   }

   /**
      Gets the largest of the added data.
      @return the maximum or 0 if no data has been added
   */
   public Measurable getMaximum()
   {
      return maximum;
   }
}

Update: Here is the solution i came up with:

public class DataSetGen <T>
{
   private double sum;
   private T maximum;
   private int count;

   /**
      Constructs an empty data set.
   */
   public DataSetGen()
   {
      sum = 0;
      count = 0;
      maximum = null;
   }

   /**
      Adds a data value to the data set.
      @param x a data value
   */
   public void add(T x)
   {
      sum = sum + x.getMeasure();
      if (count == 0 || maximum.getMeasure() < x.getMeasure())
         maximum = x;
      count++;
   }

   /**
      Gets the average of the added data.
      @return the average or 0 if no data has been added
   */
   public double getAverage()
   {
      if (count == 0) return 0;
      else return sum / count;
   }

   /**
      Gets the largest of the added data.
      @return the maximum or 0 if no data has been added
   */
   public T getMaximum()
   {
      return maximum;
   }
}

What have you tried so far? Usually Generic classes are defined like `public class DataSet` and then replacing all instances of the object you are adding with `T`, such as `public void add(T x)`.or your private variable `private T maximum;` — Orin, Sep 14 '16 at 20:46
You probably want `DataSet` then replace all `Measurable` with `T`. Purpose being the return type of `getMaximum()` can be better typed. — Andreas, Sep 14 '16 at 20:50
I am going to submit it to my Professor. I hope its correct. Thank you so much for your help everyone. — Igor Kamalov, Sep 15 '16 at 03:52
Its also my first post on stackoverflow, therefore, my apologies for breaking some rules — Igor Kamalov, Sep 15 '16 at 03:54

score 0 · Accepted Answer · answered Sep 14 '16 at 21:31

0

Start by asking yourself the question "This is supposed to be a set of ???". In your case, it's probably a set of a subclass of Measurable.

Now that you have this, you should be able to work out where to put the generic types.

answered Sep 14 '16 at 21:31

Joe C

15,324
8
38
50

I am not sure if I figured it out. – Igor Kamalov Sep 15 '16 at 03:40
I did update my answer. I think I only need to add: public class DataSetGen – Igor Kamalov Sep 15 '16 at 03:50

Converting into Generic class

1 Answers1