onNavigationItemSelected not working in NavigationView

Question

Please can someone help me with fragments from the navigation drawer, for some reason I can't get them to work and all the code looks right.

Here is the link to the source code.

Please explain the problem you are having. Saying "not working" is too broad. — Umair Farooq, Sep 10 '16 at 08:54
If you download and open up the android project you'll notice that its has a navigation drawer which I'd like to use properly, so for example I'd like to click on **The Wetlands** which in turn should change the current fragment to the **fragment_the_wetlands** I've just got a dummy clock there for now to see whether or not the fragment is changing. I can't seem to get this right please help with that. — Matt Hutchings, Sep 10 '16 at 10:52

score 38 · Answer 1 · edited Sep 12 '17 at 22:19

38

Use this code:

navigationView = (NavigationView) findViewById(R.id.navigationView); 
navigationView.bringToFront();

edited Sep 12 '17 at 22:19

andreas

16,357
12
72
76

answered Sep 12 '17 at 22:04

Vahid Rezazadeh

437
2
6
7

1

This helped me... thannks a lot !! – this is yash Nov 21 '18 at 12:10
1

Wow, I just do not understand why this worked...but it worked. – Xijukx Sep 14 '19 at 04:47
With databinding `.bringToFront()` solved the issue. So: `_binding.navView.setNavigationItemSelectedListener(this)` - not enough. Then add `_binding.navView.bringToFront()` - and the listener is triggered. – akamuza Nov 20 '19 at 11:57
Thank you, 4 days without solution and the answer was here: navigationView.bringToFront(); Thanks a lot! – hfunes.com Sep 08 '21 at 01:19

score 17 · Accepted Answer · answered Sep 12 '16 at 09:36

Have a look at your MainActivity.java.

You have implemented the callbacks for NavigationView.OnNavigationItemSelectedListener in MainActivity as below,

@Override
public boolean onNavigationItemSelected(MenuItem menuItem) {
    // blah blah
}

Also check the setupDrawerContent method.

private void setupDrawerContent(NavigationView navigationView) {
    navigationView.setNavigationItemSelectedListener(
            new NavigationView.OnNavigationItemSelectedListener() {
                @Override
                public boolean onNavigationItemSelected(MenuItem menuItem) {
                    menuItem.setChecked(true);
                    drawerLayout.closeDrawers();
                    return true;
                }
            });
}

In this method you are creating a local OnNavigationItemSelectedListener.

So you are not using the OnNavigationItemSelectedListener that you have overridden in MainActivity.

The solution is to use this as argument for setNavigationItemSelectedListener. By doing this all your clicks will go the onNavigationItemSelected of MainActivity rather than going to the local onNavigationItemSelected.

private void setupDrawerContent(NavigationView navigationView) {
    navigationView.setNavigationItemSelectedListener(this);
}

Also move the code in the local onNavigationItemSelected to the onNavigationItemSelected of MainActivity.

So your onNavigationItemSelected will be something like this,

@Override
public boolean onNavigationItemSelected(MenuItem menuItem) {
    // Handle navigation view item clicks here.
    int id = menuItem.getItemId();
    menuItem.setChecked(true);
    drawerLayout.closeDrawers();

    if (id == R.id.nav_home) {
        // Handle the home action
        Toast.makeText(this, "Home", Toast.LENGTH_SHORT).show();
    } else if (id == R.id.nav_the_wetlands) {
        Toast.makeText(this, "The Wetlands", Toast.LENGTH_SHORT).show();
        TheWetlandsFragment theWetlandsFragment = new TheWetlandsFragment();
        FragmentManager fragmentManager = getSupportFragmentManager();
        fragmentManager.beginTransaction().replace(R.id.relativelayout_for_fragment, theWetlandsFragment, theWetlandsFragment.getTag()).commit();
    } else if (id == R.id.nav_the_mistbelt_forests) {
        Toast.makeText(this, "The Mistbelt Forests", Toast.LENGTH_SHORT).show();
    }

    DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
    drawer.closeDrawer(GravityCompat.START);
    return true;
}

Also change your activity_main_drawer_view.xml as follows to solve the multiple selection issue you have in the Navigation Drawer,

<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android">

    <group android:checkableBehavior="single">
        <item
            android:id="@+id/nav_home"
            android:icon="@drawable/ic_dashboard"
            android:title="Home" />
    </group>

    <item android:title="Information">
        <group android:checkableBehavior="single">
            <item
                android:id="@+id/nav_the_wetlands"
                android:icon="@drawable/ic_event"
                android:title="The Wetlands" />
            <item
                android:id="@+id/nav_the_mistbelt_forests"
                android:icon="@drawable/ic_event"
                android:title="The Mistbelt Forests" />
            <item
                android:id="@+id/nav_the_grasslands"
                android:icon="@drawable/ic_event"
                android:title="The Grasslands" />
        </group>
    </item>

    <item android:title="Quick Go To">
        <group android:checkableBehavior="single">
            <item
                android:id="@+id/nav_accommodation"
                android:icon="@drawable/ic_event"
                android:title="Accommodation" />
            <item
                android:id="@+id/nav_cuisine"
                android:icon="@drawable/ic_forum"
                android:title="Cuisine" />
            <item
                android:id="@+id/nav_leisure_activites"
                android:icon="@drawable/ic_forum"
                android:title="Leisure &amp; Activites" />
            <item
                android:id="@+id/nav_agri_tourism"
                android:icon="@drawable/ic_forum"
                android:title="Agri-tourism" />
            <item
                android:id="@+id/nav_education"
                android:icon="@drawable/ic_forum"
                android:title="Education" />
            <item
                android:id="@+id/nav_arts_crafts_decor"
                android:icon="@drawable/ic_forum"
                android:title="Arts, Crafts &amp; DeCor" />
            <item
                android:id="@+id/nav_selective_shopping"
                android:icon="@drawable/ic_forum"
                android:title="Selective Shopping" />
            <item
                android:id="@+id/nav_for_children"
                android:icon="@drawable/ic_forum"
                android:title="For Children" />
        </group>
    </item>

    <item android:title="Midlands Animals">
        <group android:checkableBehavior="single">
            <item
                android:id="@+id/nav_midlands_birding_checklist"
                android:icon="@drawable/ic_dashboard"
                android:title="Midlands Birding Checklist" />
            <item
                android:id="@+id/nav_midlands_mammals_checklist"
                android:icon="@drawable/ic_dashboard"
                android:title="Midlands Mammals Checklist" />
        </group>
    </item>

</menu>

Good luck.

score 7 · Answer 3 · edited Jul 12 '20 at 20:10

7

Don't use

NavigationUI.setupWithNavController(navigationView, navController);

instead of it do this

navigationView.setNavigationItemSelectedListener(new NavigationView.OnNavigationItemSelectedListener() {
            @Override
            public boolean onNavigationItemSelected(@NonNull MenuItem item) {
                Toast.makeText(MainActivity.this, "clicked", Toast.LENGTH_SHORT).show();
                return false;
            }
        });

edited Jul 12 '20 at 20:10

Jithin Scaria

1,271
1
15
26

answered Jul 12 '20 at 10:05

sandeep mali

159
2
2

1

This Answer is truly a life saver – Emmanuel Njorodongo Mar 18 '21 at 12:25
For those following [this official tutorial](https://developer.android.com/guide/navigation/navigation-ui#add_a_navigation_drawer), this is the solution you want. – starbeamrainbowlabs Apr 18 '21 at 22:09

score 6 · Answer 4 · edited Sep 13 '18 at 12:14

6

I have also faced the same problem some time back, and at the end i realized that i have not wrote the 2nd line of the following code

navigationView = (NavigationView) findViewById(R.id.navigation_view);        
navigationView.setNavigationItemSelectedListener(this);

you make sure you have written the same otherwise your listener will not work

edited Sep 13 '18 at 12:14

ʍѳђઽ૯ท

16,646
7
53
108

answered Feb 07 '17 at 19:56

Ankit Pandey

220
5
9

score 1 · Answer 5 · answered Sep 15 '19 at 18:44

in my case i forgot to initialize navigation menu.

kindly follow following code:

public void initSideMenu() {

    Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
    setSupportActionBar(toolbar);

    DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
    ActionBarDrawerToggle toggle = new ActionBarDrawerToggle(
            this, drawer, toolbar, R.string.navigation_drawer_open, R.string.navigation_drawer_close);
    drawer.addDrawerListener(toggle);
    toggle.syncState();

    NavigationView navigationView = (NavigationView) findViewById(R.id.nav_view);
    navigationView.setNavigationItemSelectedListener(this);
}

happy coding...

score 1 · Answer 6 · answered Nov 18 '19 at 13:02

Make sure you have implement the interface NavigationView.OnNavigationItemSelectedListener. Second point make sure to add these lines otherwise listnere will not be called.

navigationView=(NavigationView) findviewbyid(R.id.navigation_view);
navigationView.setNavigationItemSelectedListener(this);

score 0 · Answer 7 · answered Jun 07 '21 at 07:49

0

Add this line
navigationView.bringToFront(); Its works for me

answered Jun 07 '21 at 07:49

Junaid Nawab

1

onNavigationItemSelected not working in NavigationView

7 Answers7

Linked