Dynamic Strong params for require - Rails

Question

I have an update method right now that will not work for all situations. It is hard coded in the strong params like this params.require(:integration_webhook).permit(:filters) that all fine right now but sometimes it may be integration_webhook and other times it needs to be integration_slack. Basically, is there a way that I don't need to hardcode the require in the strong params? I'll show my code for clarity.

Update Method:

    def update
     @integration = current_account.integrations.find(params[:id])

     attrs = params.require(:integration_webhook).permit(:filters)

     if @integration.update_attributes(attrs)
      flash[:success] = "Filters added"
      redirect_to account_integrations_path
     else
      render :filters
     end
   end

As you can see it's a standard update method. But I need the integration_webhook params to be dynamic. I'm wondering if there is a model method I could call to strip away the integration_webhook part?

score 2 · Accepted Answer · edited May 23 '17 at 12:22

2

Not totally sure how dynamic this needs to be, but assuming that we are either getting an integratino_webhook or a integration_slack.

def update
  @integration = current_account.integrations.find(params[:id])

  if @integration.update_attributes(update_params)
    # ...
  else
    # ...
  end
end

private
  def update_params
    params.require(:integration_webhook).permit(:filters) if params.has_key?(:integration_webhook)
    params.require(:integration_slack).permit(:filters) if params.has_key?(:integration_slack)
  end

Checkout Strong parameters require multiple if this didn't answer your question.

Edit

For more dynamic requiring:

def update_params
  [:integration_webhook, :integration_slack].each do |model|
    return params.require(model).permit(:filters) if params.has_key?(model)
  end
end

edited May 23 '17 at 12:22

Community

1
1

answered Sep 04 '16 at 23:18

fbelanger

3,522
1
17
32

Hmm.. That's interesting. That could work. I have three integrations right now and it could continue to grow. But that's seems like a decent solutions. Thanks – Bitwise Sep 04 '16 at 23:20
should this be a private method? – Bitwise Sep 04 '16 at 23:20
I'll modify the answer for more dynamic goodness and yes, this should not turn into a `ActionController::Base` action. – fbelanger Sep 04 '16 at 23:21
This won't work because it still try's to run integration_webhook which will raise `param is missing or the value is empty: integration_webhook`. – Bitwise Sep 05 '16 at 00:20
Updated answer. – fbelanger Sep 05 '16 at 00:34
how do I call that in my update method? Thanks for the help btw – Bitwise Sep 05 '16 at 00:40
Just `@integration.update_attributes(update_params)`, no? – fbelanger Sep 05 '16 at 00:42
I tried that and I got this error `When assigning attributes, you must pass a hash as an argument.` – Bitwise Sep 05 '16 at 00:44
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/122632/discussion-between-fbelanger-and-cameron-bass). – fbelanger Sep 05 '16 at 00:46

score 0 · Answer 2 · answered Sep 04 '16 at 23:35

Off the top of my head something like this should work. The naming convention isn't the best but it the structure will allow you to just add to the list if you need to.

def update
     @integration = current_account.integrations.find(params[:id])

     if @integration.update_attributes(webhook_and_slack_params)
      flash[:success] = "Filters added"
      redirect_to account_integrations_path
     else
      render :filters
     end
   end


def webhook_and_slack_params
  [:integration_webhook, :integration_slack].each do |the_params|
  if(params.has_key?(the_params))
   params.require(the_params).permit(:filters)
  end
end

Dynamic Strong params for require - Rails

Update Method:

2 Answers2

Edit

Linked