Vbscript Trim function

Question

I have a script that reads in a comma delimited text file, however whenever I use Trim(str) on one of the values I have extracted in the file, it won't work...

My Text File:

some string, anotherstring, onelaststring
some string, anotherstring, onelaststring
some string, anotherstring, onelaststring
some string, anotherstring, onelaststring

My Script:

Dim fso, myTxtFile
Set fso = CreateObject("Scripting.FileSystemObject")
Set myTxtFile = fso.OpenTextFile("mytxt.txt")

Dim str, myTxtArr
txtContents myTxtFile.ReadAll
myTxtFile.close
myTxtArr = Split(txtContents, vbNewLine)

For each line in myTxtArr
    tLine = Split(tLine, ",")
    Trim(tLine(1))
    If tLine(1) = "anotherstring" Then
        MsgBox "match"
    End If
Next

My script never reaches "match" and I'm not sure why.

`trim("some string, anotherstring, onelaststring")` is never equal to `"anotherstring"`. Perhaps you want to split the lines on ","? — John Coleman, Aug 31 '16 at 20:16
wow sorry I didn't include that part of my code, I updated it. — tarki, Aug 31 '16 at 20:17

Ken White · Accepted Answer · 2016-09-01T12:43:03.607

3

Trim() is a function that returns the trimmed string. Your code uses it improperly. You need to use the returned value:

myTxtArr(1) = Trim(myTxtArr(1))

or use another variable to store the value, and use that separate variable in the comparison,

trimmedStr = Trim(myTxtArr(1))
If trimmedStr = "anotherstring" Then

or you can just use the function return value directly in the comparison,

If Trim(myTxtArr(1)) = "anotherstring" Then

Here's a corrected version of that portion of your code:

For each line in myTxtArr
    tLine = Split(line, ",")
    tLine(1) = Trim(tLine(1))
    If tLine(1) = "anotherstring" Then
        MsgBox "match"
    End If
Next

edited Sep 01 '16 at 12:43

answered Aug 31 '16 at 20:26

Ken White

123,280
14
225
444

1

`tLine = Split(tLine, ",")` ==> `tLine = Split(line, ",")` – Ekkehard.Horner Sep 01 '16 at 07:07
@Ekkehard.Horner: Thanks. DIdn't see that error in the code I copied from the question. Thanks for pointing it out. Fixed. – Ken White Sep 01 '16 at 12:43

Vbscript Trim function

1 Answers1