Button setOnClickListener onCreateView() or onActivityCreated() in Fragment

Question

by this answer I can't understand where to put my onClickListener() - inside onCreateView() or inside onActivityCreated() , below codes describe it better:

CODE A: (Setting Button click listener inside onActivityCreated())

  private FloatingActionButton bt;      

  @Override
    public void onActivityCreated(Bundle savedInstanceState) {
        super.onActivityCreated(savedInstanceState);
        bt.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
              // do something.
            }
        });
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View v = inflater.inflate(R.layout.first_frag, container, false);
        bt = (FloatingActionButton) v.findViewById(R.id.fab);
        return v;
    }

CODE B: (Setting Button click listener inside onCreateView())

    private FloatingActionButton bt;      

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        View v = inflater.inflate(R.layout.first_frag, container, false);
        bt = (FloatingActionButton) v.findViewById(R.id.fab);
        bt.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
              // do something.
            }
        });            
        return v;
    }

I may have not understood which code is better because of my poor English, anyway, thank you all :)

In your **CODE A**, you're still initialising `bt` in `onCreateView()` so, I don't see why you don't want to set click listener there too. — Shaishav, Aug 28 '16 at 18:54
Both will have no effect as far as I know. Once the view is inflated you can put it anywhere either in onCreateView() or in onActivityCreated(). — Krupal Shah, Aug 28 '16 at 18:56

Krupal Shah · Accepted Answer · 2016-08-28T19:06:49.323

6

Both will have no effect as far as I know. Once the view is inflated you can put it anywhere either in onCreateView() or in onActivityCreated().

After all, for binding views and setting click listeners, onViewCreated() is a better candidate though, as it will be called immediately after onCreateView. It clearly suggests that your view has been inflated.

There is no specific reason or rule for it. Google itself doesn't care much about it. As a rule of thumb, you can put it anywhere you want once the view is inflated.

edited Aug 28 '16 at 19:06

answered Aug 28 '16 at 19:01

Krupal Shah

8,949
11
57
93

Okay, Thanks. also, can you give an example for something I need to call inside onActivityCreated() ? – DAVIDBALAS1 Aug 28 '16 at 19:21
2

@DAVIDBALAS1 Anything with Loader Managers. And if you need anything else from the activity view hierarchy such as Toolbar or FloatingActionButton. – Eugen Pechanec Aug 28 '16 at 19:38
@DAVIDBALAS1You can ask separate question form that. You will get answer from community. I mean I'm not free right now. – Krupal Shah Aug 28 '16 at 19:47
@KrupalShah Thanks. :) – DAVIDBALAS1 Aug 28 '16 at 19:50
The links are broken. :'( – Alston May 30 '19 at 13:32
1

@Alston Yeah. Better to check https://github.com/google/iosched source. – Krupal Shah Jun 01 '19 at 11:21
UPDATE: onActivityCreated was deprecated in API level 28! Better use onCreateView. – Rautermann Sep 03 '22 at 13:10

score 0 · Answer 2 · edited May 23 '17 at 10:29

0

I would suggest putting the onClickListener it inside the onActivityCreated. And binding the button to the view inside onCreateView. Just like you have done the first time in your question.

To read more regarding the methods you can go through this post

edited May 23 '17 at 10:29

Community

1
1

answered Aug 28 '16 at 18:55

Gaurav Sarma

2,248
2
24
45

2

Any specific reason to support this? – Shaishav Aug 28 '16 at 18:56

score 0 · Answer 3 · answered Sep 03 '22 at 13:09

0

Since onActivityCreated was deprecated in API level 28, it's probably wise to put it in onCreateView!

answered Sep 03 '22 at 13:09

Rautermann

334
3
10

Button setOnClickListener onCreateView() or onActivityCreated() in Fragment

3 Answers3

Linked