Mediaplayer stops in android after 30 clicks

Question

I've seen other posts on this but I cant figure out problem.

So I'm designing a calculator and all the numbers have one onclick method and all the operators have different . I have a method playSound() where the code is:

public void playSound(){

         MediaPlayer mp= MediaPlayer.create(this, R.raw.btn);

        setVolumeControlStream(AudioManager.STREAM_MUSIC);

        if(mp.isPlaying())
        {
            mp.stop();
            mp.reset();
        }
            mp.start();


    }

I've tried release to. Can anyone let me know the efficient way to write this. I call this method inside the onclick methods. But after around 30 clicks it stops. I've also tried to create MediaPlayer global but it still stops. I've read mediaplayer is actually costly so we can use soundpool. But even soundpool is deprecated. Any help?

Are you trying a different sound or is it always the same R.raw.btn ? — Arlind Hajredinaj, Aug 27 '16 at 19:43
I'ts always the same. I know I dont need to assign it every time but I was just messing around to find the solution — Sagar, Aug 27 '16 at 19:43

Yogesh Rathi · Accepted Answer · 2016-08-27T19:54:31.137

1

Implement onComplition() Listener , and in that listener you can call release method

You created multiple instances of mediaplayer and not release mediaplayer instanace thats why issue is came After you release called your issue will be resolved

edited Aug 27 '16 at 19:54

answered Aug 27 '16 at 19:38

Yogesh Rathi

6,331
4
51
81

In my case when each button is pressed it calls this method. So technically in calculator the sounds keep playing with push of a button, So when should i release mediaplayer? – Sagar Aug 27 '16 at 19:40
It is possible to declare mediaPlayer variable global and creare obj only once ? – Yogesh Rathi Aug 27 '16 at 19:41
What i tried, was to define a mediaplayer mp globally and during oncreate i did following: mp=MediaPlayer.create(this,R.raw.btn); and doing this stops the sound after like 10 clicks – Sagar Aug 27 '16 at 19:50
1

Ok implement onCompletion listener and write code mp.release in oncompletion method, remove global variable – Yogesh Rathi Aug 27 '16 at 19:52
I check working perfectly, in your side issue is still coming – Yogesh Rathi Aug 27 '16 at 20:03
This Worked! Thank you Very much, I've accepted the answer. Cheers – Sagar Aug 27 '16 at 20:04

score -1 · Answer 2 · answered Aug 27 '16 at 19:52

Initialize the MediaPlayer as a class attribute:

MediaPlayer media = MediaPlayer.create(this,R.raw. btn);

In the playSound() method:

public void playSound(){
        setVolumeControlStream(AudioManager.STREAM_MUSIC);
        mp.reset();
        mp.start();
    }

Mediaplayer stops in android after 30 clicks

2 Answers2