Saving user password in yii2 fails

Question

Am trying to update a users password but it fails to save it

This is the controller code:

public function actionChangepassword($id) {
    $model = new UserPass();
    $user = $this->findModel($id);

    if ($model->load(Yii::$app->request->post())) {
        if ($model->validate()) {
            try {
                $user->setPassword($_POST['UserPass']['newpass']);

                if (!$user->save()) {
                    Yii::$app->getSession()->setFlash('success', 'Password changed to ');
                    return $this->redirect(['indexi/'.$user->password]);
                } else {
                    Yii::$app->getSession()->setFlash('error', 'Password not changed');
                    return $this->redirect(['index']);
                }
            } catch (Exception $e) {
                Yii::$app->getSession()->setFlash('error', "{$e->getMessage()}");
                return $this->render('changepassword', [
                    'model' => $model
                ]);
            }
        } else {
            return $this->render('changepassword', [
                'model' => $model
            ]);
        }
    } else {
        return $this->render('changepassword', [
            'model' => $model
        ]);
    }
}

When i check var_dump($_POST['UserPass']['newpass']) it has a value;

When i try changing the part $user->setPassword($_POST['UserPass']['newpass']);

$modeluser->password = $_POST['UserPass']['newpass'];

The password is saved but not hashed,

What could be wrong

This is the setpassword function

public function setPassword($password)
{
    $this->password = Yii::$app->security->generatePasswordHash($password);
}

I think you don't need to save password as password saved into `password_hash` field if you check original advanced templates login form. Also check how password reset action working in SiteController.php — Muhammad Shahzad, Aug 10 '16 at 06:55
Not to be annoying but your `if (!$user->save()) {` seems to have the resulting actions reversed? — Blizz, Aug 10 '16 at 08:15

score 1 · Accepted Answer · answered Aug 10 '16 at 12:56

1) Change

$user->setPassword($_POST['UserPass']['newpass']);

To

$user->newpass = $user->setPassword($_POST['UserPass']['newpass']);

2) Change

public function setPassword($password)
{
    $this->password = Yii::$app->security->generatePasswordHash($password);
}

To

public function setPassword($password)
{
    return Yii::$app->security->generatePasswordHash($password);
}

score 0 · Answer 2 · answered Aug 10 '16 at 18:55

0

Best way is to look how it implemented in advanced template.

answered Aug 10 '16 at 18:55

Ярослав Гойса

183
1
7

Saving user password in yii2 fails

2 Answers2