File renameTo & File.delete

Question

I have been writing a program for batch system using quartz and i find a problem,

if(!file.renameTo(new File(PATH_FILE_PROCESSED+file.getName())))System.out.println("Cannot Move File :"+file.getAbsolutePath());
else{
    if(!file.delete())System.out.println("Cannot Delete File :"+file.getAbsolutePath());    
}

i want to move file from one directory to another directory but i can't delete the file in the same process, from my analysis i think the file haven't finished copying then running the file.delete(); my question is, is there a way to wait until the file finished copying then run the file.delete? thanks

Reading your code, it looks like you go into the `else` block when the `renameTo` call *succeeds*. So, the file does not exist at its original location anymore. So, you cannot delete it from its original location, because it isn't there anymore. — Erwin Bolwidt, Aug 02 '16 at 02:41
no renameTo in java actually copying the file not moving the file thats why i want to delete when it succeed — Michael Vinci, Aug 02 '16 at 07:30
If `File.renameTo` copies the file on your computer rather than renaming it, than you have a problem on your platform - it's not supposed to do that. The same problem may also impact the operation of the delete. — Erwin Bolwidt, Aug 02 '16 at 08:01

score 0 · Answer 1 · answered Aug 01 '16 at 07:45

0

Renaming is almost instant as it doesn't copy the file, it just moves which directory it appears in (unless you are moving between filesystems)

On windows, you can't rename or delete if you have the file open somewhere. Make sure you have close()ed it properly.

answered Aug 01 '16 at 07:45

Peter Lawrey

525,659
79
751
1,130

thanks for answering @Peter Lawrey but i java.io.File doesnt have close() command do you have any other way? – Michael Vinci Aug 01 '16 at 07:57
If closing the file is the real problem here try to look for some `InputStream`s (or `OutputStream`), `BufferedReader`, things you could have used to read/write the file. – Ephi Aug 01 '16 at 08:17
@NoobatPrograming Where are you processing the files? – Peter Lawrey Aug 01 '16 at 08:32
@PeterLawrey above that code the process is unziping the file then insert all file to db then running these code, – Michael Vinci Aug 01 '16 at 08:45
@NoobatPrograming That is the code you need to fix to ensure the files have been closed. – Peter Lawrey Aug 01 '16 at 08:46
1

@PeterLawrey i think i use zip4j to extract my file and now looking for a way maybe because in zip4j the file still open – Michael Vinci Aug 01 '16 at 09:18
@NoobatPrograming possibly. – Peter Lawrey Aug 01 '16 at 09:19

score 0 · Answer 2 · answered Aug 02 '16 at 07:35

0

i think i already found the problem, the problem is when i insert the the file inside zip some other code already insert the data so it create duplicate in database and it create an error like this. so thanks for answering the question

answered Aug 02 '16 at 07:35

Michael Vinci

105
1
8

File renameTo & File.delete

2 Answers2