Game loop doesn't work

Question

boolean running = false;
Rectangle rect = new Rectangle(10, 10, 80, 80);
JButton b = new JButton("Misca-te!");;
boolean shouldClearRect = false;
String path = new String();
BufferedImage i;
int x = 0;
double a = x;
boolean q = true;
public Thread th;

public void paintComponent(Graphics g){
    super.paintComponent(g);
    this.setBackground(Color.RED);

    g.drawImage(i, x, 0, null);
    path = "/Xture/apple.png";
    i = game2.loadImage(path);
    this.add(b);    
}

public void update(){
    x+= 1;
}

public void run(){
    int fps = 60;
    double timepertick = 1000000000 / fps;
    double delta = 0;
    long now;
    long lasttime = System.nanoTime();
    long timer = 0;
    int ticks = 0;

    while(true){
        now = System.nanoTime();
        delta += (now - lasttime)/ timepertick;
        timer += now - lasttime;
        lasttime = now;

        if(delta >= 1){
            update();
            ticks++;
            delta--;
        }
        if(timer >= 1000000000){
            System.out.println(ticks);
            ticks = 0;
            timer = 0;
        }
    }
}

public void start(){
    running = true;
    th = new Thread(this);
    th.start();
}

public static BufferedImage loadImage(String path){
    try {
        return ImageIO.read(game2.class.getResource(path));
    } catch (IOException e) {
        e.printStackTrace();
        System.exit(1);
    }
    return null;
}

This code needs to move the image by 1 pixel per second. But if I run it, it moves more than 1 pixel at a time and then it stops, and yet every second it writes "60 fps" in the console. Is something wrong with my code, or does my laptop have problems?

P.S.: the JFrame is in the main class

Wild guess: the problem is in your code, not in your laptop. — m0skit0, Jul 22 '16 at 11:28

score 0 · Answer 1 · answered Jul 22 '16 at 11:36

0

I think it would be much simpler if you did something like this:

public void run(){
    int fps = 1;
    double delay = 1000 / fps;
    int ticks = 0;
    while(true){
        delay();
        update();
        System.out.println(++ticks);
    }   
}

public void delay(int mil){
    try{
        Thread.Sleep(mil);
    }catch(Exception e){

    }
}

answered Jul 22 '16 at 11:36

nick zoum

7,216
7
36
80

Wow, what kind of loop is this? – eldo Jul 23 '16 at 17:08
@eldo Each time the while block loops the thread will sleep for a while (the time it will sleep for is 1000 / fps), and then do whatever it is supposed to do. – nick zoum Jul 23 '16 at 17:28

Game loop doesn't work

1 Answers1