Mongoid check intersecting time frames on document update

Question

I want to check if the time frame intersects with another one on a document update. It works on creation, but I'm having trouble to change anything.

This is what i have so far:

if Timetracking.where(:begin.lt => params[:timetracking][:end], :end.gt => params[:timetracking][:begin]) && Timetracking.find(params[:id]) != params[:id]
    @error = 'Time overlapping with another entry'
    render 'timetracking/edit'
else
    do update stuff
end

My basic idea was to check if the time overlaps and if the id is something else than the one I'm updating. I also tried another Query without success:

if Timetracking.where(:begin.lt => params[:timetracking][:end], :end.gt => params[:timetracking][:begin], :id.ne => params[:id])
    @error = 'Time overlapping with another entry'
    render 'timetracking/edit'
else
    do stuff
end

Now I'm a little bit stuck. Maybe someone could push me to the right direction, please. :) Oh, and I'm using Padrino.

Thank you.

score 0 · Accepted Answer · answered Jul 11 '16 at 18:57

I think you may have an error in your logic. Your code tests whether the new Timetracking is within an existing one, not whether it overlaps.

So, you have 2 possibilities. I think you will need an or statement:

It starts between another Timetracking's begin and end or
It ends between another Timetracking begin and end

Also, I suggest you write a few specs. It would make it much easier to see what is going on.

The following is not correct. It will always be false:

Timetracking.find(params[:id]) != params[:id]

You want something like:

Timetracking.where(:begin.lt ..., :id.ne => params[:id])

Thank you very much. I've solved the problem now with an OR statement. Now it works like expected. EDIT: Looks like i'm too dumb to format in comments. :) — BlindPenguin, Jul 16 '16 at 19:02

Mongoid check intersecting time frames on document update

1 Answers1