Error in Datepicker on Android

Question

I'm trying to open a dialog for picking a date on Android. Here is my code :

 et_date = (EditText) findViewById(R.id.et_date);

    et_date.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {

            DialogFragment newFragment = new DatePickerFragment();
            newFragment.show(getSupportFragmentManager(), "datePicker");



        }
    });

And I have this class :

 public static class DatePickerFragment extends DialogFragment
            implements DatePickerDialog.OnDateSetListener {

        @Override
        public Dialog onCreateDialog(Bundle savedInstanceState) {
            // Use the current date as the default date in the picker
            final Calendar c = Calendar.getInstance();
            int year = c.get(Calendar.YEAR);
            int month = c.get(Calendar.MONTH);
            int day = c.get(Calendar.DAY_OF_MONTH);

            // Create a new instance of DatePickerDialog and return it
            return new DatePickerDialog(getActivity(), this, year, month, day);
        }

        public void onDateSet(DatePicker view, int year, int month, int day) {
            // Do something with the date chosen by the user
        }
    }

And I get this error :

Attempt to invoke virtual method 'void android.widget.EditText.setOnClickListener(android.view.View$OnClickListener)' on a null object reference

How can I fix this? Thanks.

@IntelliJAmiya I still get the same error. – jason Jun 27 '16 at 07:30 — jason, Jun 27 '16 at 07:30
Actually you should pass view object . Its a fragment – IntelliJ Amiya Jun 27 '16 at 07:54 — IntelliJ Amiya, Jun 27 '16 at 07:54

Mani · Accepted Answer · 2016-06-27T07:42:33.350

1

Problem is:

et_date is null. You are tried to set listener for null object. That's why, It gives this error. Double check with your layout xml.

For debugging, just add null check and set lisetner to "et_date" as below

if (ed_date != null)
{
 // print log here to find this as error. 
// set listener here.. 
}

Update from your comments:

Add below code in your fragment. Move the variable "ed_date" to your fragment, it should not be in Activity.

@Override
public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
        super.onViewCreated(view, savedInstanceState);
        ed_date = (EditText) view.findViewById(R.id.ed_date);
}

edited Jun 27 '16 at 07:42

answered Jun 27 '16 at 07:33

Mani

17,549
13
79
100

Thanks, but how can I make it not null? Thanks. – jason Jun 27 '16 at 07:35
this answer is perfect – IntelliJ Amiya Jun 27 '16 at 07:36
2

@jason Just check your activity layout with this id "et_date". If it's not there, assign the id with corresponding text view. – Mani Jun 27 '16 at 07:36
Actually `et_date` is in a fragment which is in that activity, I call `et_date `from activity. Does this cause problem? How can I fix it? Thanks. – jason Jun 27 '16 at 07:38
Thank you very much, should I add onclick event handler to fragment as well? – jason Jun 27 '16 at 07:48
1

Ya Sure. If you are adding a code for event action which is on your fragment, event listener should be in the fragment. That' will make your code more readable. – Mani Jun 27 '16 at 07:50
One last question : After I pick date, how can I pass that date value to that `EditText` namely `et_date` – jason Jun 27 '16 at 07:56
1

you can directly write the code into this method `public void onDateSet(DatePicker view, int year, int month, int day)` as `et_date.setText(......)`... – Mani Jun 27 '16 at 07:59

Error in Datepicker on Android

1 Answers1