@Value in my spring controller does not work

Question

My controller has

@Value("${myProp}")
private String myProp;

@Bean
public static PropertySourcesPlaceholderConfigurer propertyConfigInDev() {
    return new PropertySourcesPlaceholderConfigurer();
}

@RequestMapping(value = "myProp", method = RequestMethod.GET)
public @ResponseBody String getMyProp(){
    return "The prop is:" + myProp;
}

my applicationcontext.xml has

<bean id="appConfigProperties" class="org.springframework.context.support.PropertySourcesPlaceholderConfigurer">
    <property name="location" value="classpath:MyApps-local.properties" />
</bean>

I get the following exception:

Caused by: java.lang.IllegalArgumentException: Could not resolve placeholder 'myProp' in string value "${myProp}"

Note: My properties file MyApps-local.properties is in the classpath and contains myProp=delightful

any help would be great....

How are you sure `MyApps-local.properties` is in the `classpath`? — dieend, Jun 02 '16 at 03:27
when you said it does not work in Controller, did you mean that it works for other beans? — Adrian Shum, Jun 02 '16 at 06:03

Roman Sandarkin · Accepted Answer · 2016-06-02T17:36:04.423

In XML based configuration you need to use PropertyPlaceholderConfigurer bean

<beans xmlns="http://www.springframework.org/schema/beans" . . . >
  . . .
    <bean class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
        <property name="location" value="classpath:database.properties" />
    </bean>
  . . .
</beans>

but you can use values from database.properties in xml configuration only

<beans xmlns="http://www.springframework.org/schema/beans" . . >
  . . .
    <bean id="dataSource" class="org.springframework.jdbc.datasource.DriverManagerDataSource">
        <property name="driverClassName" value="${jdbc.driverClassName}" />
        <property name="url" value="${jdbc.url}" />
        <property name="username" value="${jdbc.username}" />
        <property name="password" value="${jdbc.password}" />
    </bean>
  . . .
</beans>

If you want to use values from properties files inside @Value annotation for bean's fields, you need to add @Confuguration and @PropertySource annotation to bean class. Like this

@Configuration
@PropertySource("classpath:database.properties")
public class AppConfig {

    @Value("${jdbc.url}")
    private String url;

    @Bean
    public static PropertySourcesPlaceholderConfigurer propertyConfigInDev() {
        return new PropertySourcesPlaceholderConfigurer();
    }
}

ekem chitsiga · Answer 2 · 2016-06-02T18:08:13.290

In your configuration you have two PropertySourcesPlaceholderConfigurer. The first one define in the DispatcherServlet using Java @Configuration uses the standard environment to find properties. This means properties from system environment and environment variables as well as an defined @PropertySource.

This is not aware of your MyApps-local.properties file specified in the applicationContext.xml. The second PropertySourcesPlaceholderConfigurer in the xml file is aware of the MyApps-local.properties file but it only post process placeholder in the root application context

bean factory post processors are scoped per application context.

Change you web application context to specify the property source.This will add the properties in the file to your environment

@Configuration
@PropertySource("classpath:MyApps-local.properties")
public class WebConfig{
   @Autowired
   private Environment env;

   @RequestMapping(value = "myProp", method = RequestMethod.GET)
   public @ResponseBody String getMyProp(){
       return "The prop is:" + env.getProperty("myProp");
   }
 }

In this case you dont need the PropertySourcesPlacheholder as you can query for he properties from the environment. Then keep your applicationContext.xml as is

It will also work with the PropertySourcesPlaceholder @Bean as it also picks properties from the enviroment. However the abover is clean than below

@Configuration
@PropertySource("classpath:MyApps-local.properties")
public class WebConfig{

   @Value("${myProp}")
   private String myProp;

   @Bean
   public static PropertySourcesPlaceholderConfigurer propertyConfigInDev() {
     return new PropertySourcesPlaceholderConfigurer();
   }

   @RequestMapping(value = "myProp", method = RequestMethod.GET)
   public @ResponseBody String getMyProp(){
     return "The prop is:" + myProp;
   }
}

score 1 · Answer 3 · answered Jun 02 '16 at 18:38

See if this helps

You could go on and use this util tag in your xml configuration

<util:properties id="appConfigProperties" location="location to your properties file" /> <context:property-placeholder properties-ref="appConfigProperties" />

Comes from schema http://www.springframework.org/schema/util http://www.springframework.org/schema/util/spring-util-3.1.xsd
Then in you code where you want your value from property file use it as

@Value("${myPropl}")
private String str;

works for me, let me know if stuck any where :)

score -1 · Answer 4 · answered Jun 01 '16 at 22:01

-1

Read carefully this http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html#boot-features-external-config-application-property-files

For dev-mode use profile-specific properties

answered Jun 01 '16 at 22:01

Sergey Bulavkin

2,325
2
17
26

so what's the problem? And, OP has not said that he is using spring boot. I have no idea how the page which describe the spring-boot-provided behavior is related to the question – Adrian Shum Jun 02 '16 at 06:05

@Value in my spring controller does not work

4 Answers4