SDWebImage downloading but not show image

Question

I'm using UICollectionView.

Images are coming from FTP server. Here is my code for downloading and Showing image on button :

[tempp sd_setImageWithURL:[NSURL URLWithString:[[arrFilterData objectAtIndex:indexPath.row] valueForKey:@"ZoomPrdImg"]] //PrdImg //ZoomPrdImg
             placeholderImage:nil
                    completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, NSURL *imageURL) {
                        if (image) {
                            myCell.image.userInteractionEnabled = YES;
                            dispatch_async(dispatch_get_main_queue(), ^{
                                [myCell.image setImage:image forState:UIControlStateNormal];
                                [myCell setNeedsLayout];
                            });
                        }
                    }];

myCell.image is my button that set downloaded image. Now I don't get that image is successfully dowloaded but nut show in button. There's 3000+ images in UICollectionView but it shows some image and some blank.

How this possible ? How to solve this ? What is issue there ?

EDIT: tempp is allocted in viewDidLoad

- (void)viewDidLoad {
    tempp = [[UIImageView alloc] init];
}

can u explain what is tempp.image in this line [myCell.image setImage:tempp.image forState:UIControlStateNormal]; — Muhammad Waqas Bhati, May 30 '16 at 05:53
as i mention in my quen myCell.image is my button that i set downloaded image into it. — Darshan Gajera, May 30 '16 at 05:54
use placeholder image instead of using `NIL` and make sure your image url is correct. — Nitin Gohel, May 30 '16 at 05:58
I tried this already but it's same issue there.@MuhammadWaqasBhati and @NitinGohel — Darshan Gajera, May 30 '16 at 05:59
And last question where do you call sd_setImageWithURL code? — Andrew Romanov, May 30 '16 at 06:06
in UICollectionView's delegate method cellForItemAtIndexPath. — Darshan Gajera, May 30 '16 at 06:09
See my answer, you call async meth on one object, it is not right method. — Andrew Romanov, May 30 '16 at 06:13
Is you server directory or image file is public? OR do you given permission to access these images for particular user? Is your files are private on server than you can not access it. — Ajay Gabani, May 30 '16 at 07:13

score 0 · Answer 1 · answered May 30 '16 at 05:55

0

replace

 [myCell.image setImage:tempp.image forState:UIControlStateNormal];
                            [myCell setNeedsLayout];

with

 [myCell.image setImage:image forState:UIControlStateNormal];
                            [myCell setNeedsLayout];

Because in your completion handler you are getting your image in image object

answered May 30 '16 at 05:55

Ketan Parmar

27,092
9
50
75

then check `error` from that completion handler. Because you are not getting image i think – Ketan Parmar May 30 '16 at 06:01
no there's no error there it downloaded successfully. – Darshan Gajera May 30 '16 at 06:16

Andrew Romanov · Answer 2 · 2016-05-30T06:23:40.477

0

I think your variable tempp is destructed, and cancels request for the image. Change request code to

[myButton sd_setImageWithURL:[NSURL URLWithString:@"MyURL"] forState:UIControlStateNormal completed:yourCompletitionBlock];

And all should be fine.

UPD

Based on your answer about tempp variable, I think you see one Image per page, because when you call sd_setImage... for many cells, only last request is loading. Requests are asynchronous and if you request new image, old request is cancelled.

Code from SDWebImage:

- (void)sd_setImageWithURL:(NSURL *)url placeholderImage:(UIImage *)placeholder options:(SDWebImageOptions)options progress:(SDWebImageDownloaderProgressBlock)progressBlock completed:(SDWebImageCompletionBlock)completedBlock {
    [self sd_cancelCurrentImageLoad];
    objc_setAssociatedObject(self, &imageURLKey, url, OBJC_ASSOCIATION_RETAIN_NONATOMIC);

First line cancels old request.

edited May 30 '16 at 06:23

answered May 30 '16 at 06:05

Andrew Romanov

4,774
3
25
40

sd_setImageWithURL is works but it crashes after some time, and exception is : CoreFoundation`CFGetTypeID: -------- how to get rid of this. ? – Darshan Gajera May 30 '16 at 06:28
I think you is not correct using the method, can you show new code? – Andrew Romanov May 30 '16 at 07:17
which code ? and im getting image from ftp server so is it making any issues? – Darshan Gajera May 30 '16 at 08:23
you should't use tempp, use myCell.image. Using of tempp is main mistake, other is not so bad. – Andrew Romanov May 30 '16 at 08:43

SDWebImage downloading but not show image

2 Answers2