onclick listener for preference activity in Android

Question

I was following this documentations to create a setting page. I have created two java classes based on the documentation:

SettingsFragment.java:

public static class SettingsFragment extends PreferenceFragment {
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        // Load the preferences from an XML resource
        addPreferencesFromResource(R.xml.preferences);
    }
    ...
}

SettingsActivity.java

public class SettingsActivity extends AppCompatActivity {
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        // Display the fragment as the main content.
        getFragmentManager().beginTransaction()
                .replace(android.R.id.content, new SettingsFragment())
                .commit();
    }
}

In the preference I have an item with key premium_support which I want to create a click listener for it.

 <CheckBoxPreference
        android:key="@string/premium_support"
        android:title="Premium Support"
        android:summary="Purchase premium support"
        android:defaultValue="false" />

I can't create a click listener in the fragment because I have my in app billing codes in the SettingsActivity. I tried this answer but seems like findPreference is only for the preferencefragment.

Any idea how to implement the click listener in SettingsActivity?

Darush · Answer 1 · 2018-03-15T05:24:08.173

6

In the onCreate() method of SettingsActivity:

Preference preference = findPreference("prefs_key");
preference.setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
   @Override
   public boolean onPreferenceClick(Preference preference) {
       Toast.makeText(SettingsActivity.this, "Clicked", Toast.LENGTH_SHORT).show();
       return true;
   }
});

edited Mar 15 '18 at 05:24

answered Nov 02 '16 at 10:56

Darush

11,403
9
62
60

1

A side note: It should `return true` if the click has been handled. – Daksh Mar 15 '18 at 04:57
@Daksh Thanks for pointing that out. I have changed it to return true. – Darush Mar 15 '18 at 05:25

score 1 · Answer 2 · answered May 12 '19 at 08:09

The 'findPreference' method can only be called on the settingsfragment because it extends preferencefragment. You need to get a reference to the settingsfragment class in the settings activity like below:

    private SettingsFragment settingsFragment;

 @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setTitle("SETTINGS");

         //instantiate the settings fragment
         settingsFragment= new SettingsFragment();
        getFragmentManager().beginTransaction()
                .replace(android.R.id.content, settingsFragment)
                .commit();
    }

You then override onResume and set the preferenceclicklistener in onresume and not oncreate because the commit() method is called asynchronously ( i.e the code does not execute immediately) and the preference value might be null if you call findpreference immediately after commiting the fragment transaction in oncreate.

    @Override
        protected void onResume() {
            super.onResume();
            Preference preference = 
          settingsFragment.findPreference(getString(R.string.pref_key));
            preference.setOnPreferenceClickListener(new 
            Preference.OnPreferenceClickListener() {
                @Override
                public boolean onPreferenceClick(Preference preference) {
                   //respond to click events here
                    return true;
                }
            });

        }

Do we also have to unregister the OnPreferenceClickListener? — Patrick, Dec 24 '21 at 17:18

onclick listener for preference activity in Android

2 Answers2