23

In Node with Express, I have a piece of code like this. 

 if (req.body.var1 >= req.body.var2){
        res.json({success: false, message: "End time must be AFTER start time"});
        console.log('Hi')
 }
 console.log('Hi2')
 //other codes

I expected that if var1 is >= var2, the response would be sent and the execution would end. Like return statements in Java/C#

But appearantly that's not the case. After the response is sent, both 'Hi' and 'Hi2' and all the other code after that continues to get executed.

I was wondering how I would stop this from happening?

Also, I was wondering under what circumstances would you actually want code to keep on executing after a response has already been sent.

Cheers

davidx1
  • 3,525
  • 9
  • 38
  • 65

3 Answers3

24

Express just calls a JavaScript function for the matched route. There's no special magic to know when the function is complete/incomplete. It just runs the function. However, it's very easy to exit the function whenever you want...

You can use return to stop executing the callback for a specific route in express. It's just JavaScript... the function will always attempt to run to completion

app.post('/some/route', (req, res)=> {
  if (req.body.var1 >= req.body.var2){
    // note the use of `return` here
    return res.json({success: false, message: "End time must be AFTER start time"});
    // this line will never get called
    console.log('Hi')
  }
  // this code will only happen if the condition above is false
  console.log('Hi2')
  //other codes
});

Warning about string comparsion

You're using

req.body.var1 >= req.body.var2

All HTML form values are sent to the server as strings.

// javascript string comparison
"4" > "3"  //=> true
"4" > "30" //=> true
parseInt("4", 10) > parseInt("30", 10) //=> false

I'm certain you'll need to make a more educated comparison than that. It looks like they're time values? So you'll likely want to convert those values to Date objects and do an accurate comparison.

Mulan
  • 129,518
  • 31
  • 228
  • 259
  • 1
    Yes, they are integer values for seconds. Thanks for the warning! I suppose I'll need to just parse them like you did? I didn't know that everything is sent as strings. That could've caused me a lot of headaches down the line. Thanks so much. – davidx1 May 19 '16 at 19:56
8

Simply return after the res.json function:

res.json({success: false, message: "End time must be AFTER start time"});
return; // This will stop anything else from being run
James111
  • 15,378
  • 15
  • 78
  • 121
3

You can return with res.json too.

if (req.body.var1 >= req.body.var2){
return res.status(400).json({success: false, message: 'your message'})
}
Renan Bardy
  • 33
  • 4